Utils: Rename QtcProcess::Result::Finished to FinishedWithSuccess

To make clear that this is not just any finish.

Also change FinishedError to FinishedWithError, to create
symmetry.

Also adapt enum member description to reality.

Change-Id: I13e05391eb86fdb24e2ae660f14dfddb282e1104
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

1 files changed, 2 insertions, 2 deletions

diff --git a/src/plugins/git/gerrit/gerritserver.cpp b/src/plugins/git/gerrit/gerritserver.cpp
index 0944b7ee82..2429e16d97 100644
--- a/src/plugins/git/gerrit/gerritserver.cpp
+++ b/src/plugins/git/gerrit/gerritserver.cpp
@@ -247,7 +247,7 @@ int GerritServer::testConnection()
     SynchronousProcess proc;
     client->vcsFullySynchronousExec(proc, QString(), {curlBinary, arguments},
                                     Core::ShellCommand::NoOutput);
-    if (proc.result() == QtcProcess::Finished) {
+    if (proc.result() == QtcProcess::FinishedWithSuccess) {
         QString output = proc.stdOut();
         // Gerrit returns an empty response for /p/qt-creator/a/accounts/self
         // so consider this as 404.
@@ -358,7 +358,7 @@ void GerritServer::resolveVersion(const GerritParameters &p, bool forceReload)
                                         Core::ShellCommand::NoOutput);
         // REST endpoint for version is only available from 2.8 and up. Do not consider invalid
         // if it fails.
-        if (proc.result() == QtcProcess::Finished) {
+        if (proc.result() == QtcProcess::FinishedWithSuccess) {
             QString output = proc.stdOut();
             if (output.isEmpty())
                 return;