debugger: The DebuggerEngine refactoring.

This replaces the (de facto) singleton engines and data handlers by classes
that are instantiated per run. The DebuggerRunControl will now create an
object of (a class derived from) DebuggerEngine that contains all the relevant
"dynamic" data.

DebuggerManager is no more. The "singleton" bits are merged into DebuggerPlugin,
whereas the data bits went to DebuggerEngine.

There is no formal notion of a "current" DebuggerEngine. However, as there's
only one DebuggerEngine at a time that has its data models connected to the
view, there's still some "de facto" notion of a "current" engine. Calling
SomeModel::setData(int role, QVariant data) with custom role is used as the
primary dispatch mechanism from the views to the "current" data models
(and the engine, as all data models know their engine).

1 files changed, 10 insertions, 8 deletions

diff --git a/src/plugins/debugger/cdb/cdbstacktracecontext.cpp b/src/plugins/debugger/cdb/cdbstacktracecontext.cpp
index 23a5543301..6fc617f532 100644
--- a/src/plugins/debugger/cdb/cdbstacktracecontext.cpp
+++ b/src/plugins/debugger/cdb/cdbstacktracecontext.cpp
@@ -28,10 +28,12 @@
 **************************************************************************/
 
 #include "cdbstacktracecontext.h"
+
 #include "cdbsymbolgroupcontext.h"
 #include "cdbdumperhelper.h"
 #include "cdbdebugengine_p.h"
 #include "debuggeractions.h"
+#include "debuggerplugin.h"
 #include "watchutils.h"
 #include "threadshandler.h"
 
@@ -61,18 +63,18 @@ CdbStackTraceContext *CdbStackTraceContext::create(const QSharedPointer<CdbDumpe
     return ctx;
 }
 
-CdbCore::SymbolGroupContext
-        *CdbStackTraceContext::createSymbolGroup(const CdbCore::ComInterfaces & /* cif */,
-                                                 int index,
-                                                 const QString &prefix,
-                                                 CIDebugSymbolGroup *comSymbolGroup,
-                                                 QString *errorMessage)
+CdbCore::SymbolGroupContext *
+CdbStackTraceContext::createSymbolGroup(const CdbCore::ComInterfaces & /* cif */,
+                                        int index,
+                                        const QString &prefix,
+                                        CIDebugSymbolGroup *comSymbolGroup,
+                                        QString *errorMessage)
 {
     // Exclude uninitialized variables if desired
     QStringList uninitializedVariables;
     const CdbCore::StackFrame &frame = stackFrameAt(index);
     if (theDebuggerAction(UseCodeModel)->isChecked())
-        getUninitializedVariables(DebuggerManager::instance()->cppCodeModelSnapshot(), frame.function, frame.fileName, frame.line, &uninitializedVariables);
+        getUninitializedVariables(DebuggerPlugin::instance()->cppCodeModelSnapshot(), frame.function, frame.fileName, frame.line, &uninitializedVariables);
     if (debug)
         qDebug() << frame << uninitializedVariables;
     CdbSymbolGroupContext *sc = CdbSymbolGroupContext::create(prefix,
@@ -113,7 +115,7 @@ QList<StackFrame> CdbStackTraceContext::stackFrames() const
 }
 
 bool CdbStackTraceContext::getThreads(const CdbCore::ComInterfaces &cif,
-                                      QList<ThreadData> *threads,
+                                      Threads *threads,
                                       ULONG *currentThreadId,
                                       QString *errorMessage)
 {