summaryrefslogtreecommitdiff
path: root/src/plugins/coreplugin
diff options
context:
space:
mode:
authorKai Koehne <kai.koehne@digia.com>2014-08-29 14:00:18 +0200
committerhjk <hjk121@nokiamail.com>2014-09-04 14:50:00 +0200
commite2584f69d446a846fa712081322f2988ac3d5bc8 (patch)
tree9f601f99959b71384890beaf361844afcd7486cc /src/plugins/coreplugin
parentd4a7505a181d0147b0151a18eca266ed35e26c4e (diff)
downloadqt-creator-e2584f69d446a846fa712081322f2988ac3d5bc8.tar.gz
Replace QLatin1String("x") with QLatin1Char('x') where possible
Change-Id: I2f90c8ae7b5e968b9de882833f8661ab540a9232 Reviewed-by: hjk <hjk121@nokiamail.com>
Diffstat (limited to 'src/plugins/coreplugin')
-rw-r--r--src/plugins/coreplugin/patchtool.cpp2
-rw-r--r--src/plugins/coreplugin/testdatadir.cpp2
-rw-r--r--src/plugins/coreplugin/toolsettings.cpp2
-rw-r--r--src/plugins/coreplugin/variablechooser.cpp2
-rw-r--r--src/plugins/coreplugin/vcsmanager.cpp4
5 files changed, 6 insertions, 6 deletions
diff --git a/src/plugins/coreplugin/patchtool.cpp b/src/plugins/coreplugin/patchtool.cpp
index 83e2ce7104..578a54841f 100644
--- a/src/plugins/coreplugin/patchtool.cpp
+++ b/src/plugins/coreplugin/patchtool.cpp
@@ -100,7 +100,7 @@ bool PatchTool::runPatch(const QByteArray &input, const QString &workingDirector
args << QLatin1String("-R");
MessageManager::write(QApplication::translate("Core::PatchTool", "Executing in %1: %2 %3").
arg(QDir::toNativeSeparators(workingDirectory),
- QDir::toNativeSeparators(patch), args.join(QLatin1String(" "))));
+ QDir::toNativeSeparators(patch), args.join(QLatin1Char(' '))));
patchProcess.start(patch, args);
if (!patchProcess.waitForStarted()) {
MessageManager::write(QApplication::translate("Core::PatchTool", "Unable to launch \"%1\": %2").arg(patch, patchProcess.errorString()));
diff --git a/src/plugins/coreplugin/testdatadir.cpp b/src/plugins/coreplugin/testdatadir.cpp
index 5bbc946f88..78da242b07 100644
--- a/src/plugins/coreplugin/testdatadir.cpp
+++ b/src/plugins/coreplugin/testdatadir.cpp
@@ -62,7 +62,7 @@ QString TestDataDir::directory(const QString &subdir, bool clean) const
{
QString path = m_directory;
if (!subdir.isEmpty())
- path += QLatin1String("/") + subdir;
+ path += QLatin1Char('/') + subdir;
if (clean)
path = QDir::cleanPath(path);
maybeAppendSlash(&path);
diff --git a/src/plugins/coreplugin/toolsettings.cpp b/src/plugins/coreplugin/toolsettings.cpp
index da5d1f4f77..930badc9d7 100644
--- a/src/plugins/coreplugin/toolsettings.cpp
+++ b/src/plugins/coreplugin/toolsettings.cpp
@@ -71,7 +71,7 @@ static QString getUserFilePath(const QString &proposalFileName)
if (!resourceDir.exists(QLatin1String("externaltools")))
resourceDir.mkpath(QLatin1String("externaltools"));
const QFileInfo fi(proposalFileName);
- const QString &suffix = QLatin1String(".") + fi.completeSuffix();
+ const QString &suffix = QLatin1Char('.') + fi.completeSuffix();
const QString &newFilePath = ICore::userResourcePath()
+ QLatin1String("/externaltools/") + fi.baseName();
int count = 0;
diff --git a/src/plugins/coreplugin/variablechooser.cpp b/src/plugins/coreplugin/variablechooser.cpp
index 12819f7e35..0532213415 100644
--- a/src/plugins/coreplugin/variablechooser.cpp
+++ b/src/plugins/coreplugin/variablechooser.cpp
@@ -319,7 +319,7 @@ void VariableChooserPrivate::handleItemActivated(QListWidgetItem *item)
*/
void VariableChooserPrivate::insertVariable(const QString &variable)
{
- const QString &text = QLatin1String("%{") + variable + QLatin1String("}");
+ const QString &text = QLatin1String("%{") + variable + QLatin1Char('}');
if (m_lineEdit) {
m_lineEdit->insert(text);
m_lineEdit->activateWindow();
diff --git a/src/plugins/coreplugin/vcsmanager.cpp b/src/plugins/coreplugin/vcsmanager.cpp
index 97a646173d..8a22994e8a 100644
--- a/src/plugins/coreplugin/vcsmanager.cpp
+++ b/src/plugins/coreplugin/vcsmanager.cpp
@@ -247,7 +247,7 @@ IVersionControl* VcsManager::findVersionControlForDirectory(const QString &input
// Make sure we an absolute path:
QString directory = QDir(inputDirectory).absolutePath();
#ifdef WITH_TESTS
- if (directory[0].isLetter() && directory.indexOf(QLatin1String(":") + QLatin1String(TEST_PREFIX)) == 1)
+ if (directory[0].isLetter() && directory.indexOf(QLatin1Char(':') + QLatin1String(TEST_PREFIX)) == 1)
directory = directory.mid(2);
#endif
VcsManagerPrivate::VcsInfo *cachedData = d->findInCache(directory);
@@ -634,7 +634,7 @@ void CorePlugin::testVcsManager()
foreach (const QString &result, results) {
// qDebug() << "Expecting:" << result;
- QStringList split = result.split(QLatin1String(":"));
+ QStringList split = result.split(QLatin1Char(':'));
QCOMPARE(split.count(), 4);
QVERIFY(split.at(3) == QLatin1String("*") || split.at(3) == QLatin1String("-"));