summaryrefslogtreecommitdiff
path: root/src/plugins/cmakeprojectmanager/cmakeprojectnodes.cpp
diff options
context:
space:
mode:
authorAlessandro Portale <alessandro.portale@qt.io>2021-02-09 21:37:21 +0100
committerAlessandro Portale <alessandro.portale@qt.io>2021-02-10 10:32:15 +0000
commit9e2c6fbfca99b8a1e2eccbe76a0715a2070cbf4c (patch)
tree3409b1fa3008086e97ffe50f1641a544d202c639 /src/plugins/cmakeprojectmanager/cmakeprojectnodes.cpp
parent67788a90bb115d3cd7cc5245e64028df7b4a9d1d (diff)
downloadqt-creator-9e2c6fbfca99b8a1e2eccbe76a0715a2070cbf4c.tar.gz
Android: Deduplicate string literals and use constants instead
Improves findability of identical string in code (via code model). Reduces risk of typos. Change-Id: I0e9d9af8eed5cd9b66bf303cfee99c53513bf314 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Diffstat (limited to 'src/plugins/cmakeprojectmanager/cmakeprojectnodes.cpp')
-rw-r--r--src/plugins/cmakeprojectmanager/cmakeprojectnodes.cpp12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/plugins/cmakeprojectmanager/cmakeprojectnodes.cpp b/src/plugins/cmakeprojectmanager/cmakeprojectnodes.cpp
index d75f75076d..4fa34cba60 100644
--- a/src/plugins/cmakeprojectmanager/cmakeprojectnodes.cpp
+++ b/src/plugins/cmakeprojectmanager/cmakeprojectnodes.cpp
@@ -129,22 +129,22 @@ QVariant CMakeTargetNode::data(Utils::Id role) const
};
if (role == Android::Constants::AndroidPackageSourceDir)
- return value("ANDROID_PACKAGE_SOURCE_DIR");
+ return value(Android::Constants::ANDROID_PACKAGE_SOURCE_DIR);
if (role == Android::Constants::AndroidDeploySettingsFile)
- return value("ANDROID_DEPLOYMENT_SETTINGS_FILE");
+ return value(Android::Constants::ANDROID_DEPLOYMENT_SETTINGS_FILE);
if (role == Android::Constants::AndroidExtraLibs)
- return value("ANDROID_EXTRA_LIBS");
+ return value(Android::Constants::ANDROID_EXTRA_LIBS);
if (role == Android::Constants::ANDROID_APPLICATION_ARGUMENTS)
- return value("QT_ANDROID_APPLICATION_ARGUMENTS");
+ return value(Android::Constants::QT_ANDROID_APPLICATION_ARGUMENTS);
if (role == Android::Constants::AndroidArch)
- return value("ANDROID_ABI");
+ return value(Android::Constants::ANDROID_ABI);
if (role == Android::Constants::AndroidSoLibPath)
- return values("ANDROID_SO_LIBS_PATHS");
+ return values(Android::Constants::ANDROID_SO_LIBS_PATHS);
if (role == Android::Constants::AndroidTargets)
return values("TARGETS_BUILD_PATH");