diff options
author | hjk <hjk@qt.io> | 2020-02-05 09:27:26 +0100 |
---|---|---|
committer | hjk <hjk@qt.io> | 2020-02-06 07:03:44 +0000 |
commit | 7f37c503db291d031770701cd0b912405597dbb7 (patch) | |
tree | b20a9480011e16bc7c72bce627d182f9a62b7b1d /src/plugins/clearcase/clearcasesubmiteditor.cpp | |
parent | c17767c78ebc6b3d3b66e4d78d46b0eef4ac003f (diff) | |
download | qt-creator-7f37c503db291d031770701cd0b912405597dbb7.tar.gz |
Vcs: Move responsibility to set editor parameters to editor factory
So it doesn't need to be named twice in the editor factory setup.
This intentially includes a de-optimiztion: storing the parameters
by value, not by pointer. That's more natural, does not need to
keep the parameters alive on the caller side, and it's uncritical
in this context.
Change-Id: I92867d3f2f75c38911ae82d3eeb4759cba71b723
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/clearcase/clearcasesubmiteditor.cpp')
-rw-r--r-- | src/plugins/clearcase/clearcasesubmiteditor.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/clearcase/clearcasesubmiteditor.cpp b/src/plugins/clearcase/clearcasesubmiteditor.cpp index eed9cf193c..6973e36602 100644 --- a/src/plugins/clearcase/clearcasesubmiteditor.cpp +++ b/src/plugins/clearcase/clearcasesubmiteditor.cpp @@ -33,8 +33,8 @@ using namespace ClearCase::Internal; -ClearCaseSubmitEditor::ClearCaseSubmitEditor(const VcsBase::VcsBaseSubmitEditorParameters *parameters) : - VcsBase::VcsBaseSubmitEditor(parameters, new ClearCaseSubmitEditorWidget) +ClearCaseSubmitEditor::ClearCaseSubmitEditor() : + VcsBase::VcsBaseSubmitEditor(new ClearCaseSubmitEditorWidget) { document()->setPreferredDisplayName(tr("ClearCase Check In")); } |