summaryrefslogtreecommitdiff
path: root/src/plugins/clangtools
diff options
context:
space:
mode:
authorNikolai Kosjar <nikolai.kosjar@qt.io>2018-05-16 13:24:40 +0200
committerNikolai Kosjar <nikolai.kosjar@qt.io>2018-05-18 06:28:12 +0000
commit73d908bf2be75baff72da4da3daf6bbe51b245d2 (patch)
tree6826f90d0199711ef8ea34b0ec052f978d298383 /src/plugins/clangtools
parentf083293c317129dfb411c6b5611c505b148733fc (diff)
downloadqt-creator-73d908bf2be75baff72da4da3daf6bbe51b245d2.tar.gz
ClangTools: Disable fixits checkboxes for diagnostics without fixits
Change-Id: Ie65fad3acd2a84bbb7ecb40e05d3a43cf89be11f Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Diffstat (limited to 'src/plugins/clangtools')
-rw-r--r--src/plugins/clangtools/clangtoolsdiagnosticmodel.cpp12
1 files changed, 9 insertions, 3 deletions
diff --git a/src/plugins/clangtools/clangtoolsdiagnosticmodel.cpp b/src/plugins/clangtools/clangtoolsdiagnosticmodel.cpp
index 1f1dba4039..1834ef02d7 100644
--- a/src/plugins/clangtools/clangtoolsdiagnosticmodel.cpp
+++ b/src/plugins/clangtools/clangtoolsdiagnosticmodel.cpp
@@ -221,9 +221,15 @@ DiagnosticItem::DiagnosticItem(const Diagnostic &diag, const OnCheckedFixit &onC
Qt::ItemFlags DiagnosticItem::flags(int column) const
{
- if (column == DiagnosticView::FixItColumn && m_diagnostic.hasFixits)
- return TreeItem::flags(column) | Qt::ItemIsUserCheckable;
- return TreeItem::flags(column);
+ const Qt::ItemFlags itemFlags = TreeItem::flags(column);
+ if (column == DiagnosticView::FixItColumn) {
+ if (m_diagnostic.hasFixits)
+ return itemFlags | Qt::ItemIsUserCheckable;
+ else
+ return itemFlags & ~Qt::ItemIsEnabled;
+ }
+
+ return itemFlags;
}
static QVariant locationData(int role, const Debugger::DiagnosticLocation &location)