From 73d908bf2be75baff72da4da3daf6bbe51b245d2 Mon Sep 17 00:00:00 2001 From: Nikolai Kosjar Date: Wed, 16 May 2018 13:24:40 +0200 Subject: ClangTools: Disable fixits checkboxes for diagnostics without fixits Change-Id: Ie65fad3acd2a84bbb7ecb40e05d3a43cf89be11f Reviewed-by: Ivan Donchevskii --- src/plugins/clangtools/clangtoolsdiagnosticmodel.cpp | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) (limited to 'src/plugins/clangtools') diff --git a/src/plugins/clangtools/clangtoolsdiagnosticmodel.cpp b/src/plugins/clangtools/clangtoolsdiagnosticmodel.cpp index 1f1dba4039..1834ef02d7 100644 --- a/src/plugins/clangtools/clangtoolsdiagnosticmodel.cpp +++ b/src/plugins/clangtools/clangtoolsdiagnosticmodel.cpp @@ -221,9 +221,15 @@ DiagnosticItem::DiagnosticItem(const Diagnostic &diag, const OnCheckedFixit &onC Qt::ItemFlags DiagnosticItem::flags(int column) const { - if (column == DiagnosticView::FixItColumn && m_diagnostic.hasFixits) - return TreeItem::flags(column) | Qt::ItemIsUserCheckable; - return TreeItem::flags(column); + const Qt::ItemFlags itemFlags = TreeItem::flags(column); + if (column == DiagnosticView::FixItColumn) { + if (m_diagnostic.hasFixits) + return itemFlags | Qt::ItemIsUserCheckable; + else + return itemFlags & ~Qt::ItemIsEnabled; + } + + return itemFlags; } static QVariant locationData(int role, const Debugger::DiagnosticLocation &location) -- cgit v1.2.1