diff options
| author | hjk <hjk@qt.io> | 2019-12-12 17:41:43 +0100 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2020-01-16 09:44:31 +0000 |
| commit | 3d7a3b4749abad409663806cadec535fb3a041b6 (patch) | |
| tree | b295de8af1cf1f4d6b2ea96b5ed12164e480b4d5 /src/plugins/baremetal/idebugserverprovider.cpp | |
| parent | 66371198ecbc47e3eae87f63997eb0c189dc83be (diff) | |
| download | qt-creator-3d7a3b4749abad409663806cadec535fb3a041b6.tar.gz | |
BareMetal: De-virtualize IDebugServerProvider::createConfigWidget
There is no change in functionality intended.
The original version is good in principle, but Creator core has been
moving to use this 'setFoo(std::function<>)' pattern during the last
year, greatly reducing the need for boilerplate on the "user" side.
The effect isn't as significant here, but generally I don't want to
use too many different patterns being used.
Change-Id: I3ec8c677c19c1ed3f8145e0c3cba337dff7ce1cf
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Diffstat (limited to 'src/plugins/baremetal/idebugserverprovider.cpp')
| -rw-r--r-- | src/plugins/baremetal/idebugserverprovider.cpp | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/src/plugins/baremetal/idebugserverprovider.cpp b/src/plugins/baremetal/idebugserverprovider.cpp index 1788f8df70..b092de9049 100644 --- a/src/plugins/baremetal/idebugserverprovider.cpp +++ b/src/plugins/baremetal/idebugserverprovider.cpp @@ -155,6 +155,12 @@ bool IDebugServerProvider::operator==(const IDebugServerProvider &other) const && m_channel == other.m_channel; } +IDebugServerProviderConfigWidget *IDebugServerProvider::configurationWidget() const +{ + QTC_ASSERT(m_configurationWidgetCreator, return nullptr); + return m_configurationWidgetCreator(); +} + QVariantMap IDebugServerProvider::toMap() const { return { @@ -197,6 +203,11 @@ bool IDebugServerProvider::fromMap(const QVariantMap &data) return true; } +void IDebugServerProvider::setConfigurationWidgetCreator(const std::function<IDebugServerProviderConfigWidget *()> &configurationWidgetCreator) +{ + m_configurationWidgetCreator = configurationWidgetCreator; +} + // IDebugServerProviderFactory QString IDebugServerProviderFactory::id() const |