diff options
author | Tobias Hunger <tobias.hunger@qt.io> | 2016-07-20 13:44:47 +0200 |
---|---|---|
committer | Tobias Hunger <tobias.hunger@qt.io> | 2016-07-21 12:53:36 +0000 |
commit | 1063ed3a4a7a789cd080bac7a2e28ae6285382c9 (patch) | |
tree | b351b790c49490310aa1e4cb8df1a6888f8b2db4 /src/libs/utils/synchronousprocess.cpp | |
parent | ff6251cbe2031370caff526f78a62144e17b6e8a (diff) | |
download | qt-creator-1063ed3a4a7a789cd080bac7a2e28ae6285382c9.tar.gz |
SynchronousProcess: Small cleanups
* Use class, not struct, according to coding style
Change-Id: I3aa14eb9f480d7b07fb015b8694aae6fcc60c169
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/libs/utils/synchronousprocess.cpp')
-rw-r--r-- | src/libs/utils/synchronousprocess.cpp | 17 |
1 files changed, 3 insertions, 14 deletions
diff --git a/src/libs/utils/synchronousprocess.cpp b/src/libs/utils/synchronousprocess.cpp index 824e079557..7852cc88da 100644 --- a/src/libs/utils/synchronousprocess.cpp +++ b/src/libs/utils/synchronousprocess.cpp @@ -106,12 +106,6 @@ void TerminalControllingProcess::setupChildProcess() } // ----------- SynchronousProcessResponse -SynchronousProcessResponse::SynchronousProcessResponse() : - result(StartFailed), - exitCode(-1) -{ -} - void SynchronousProcessResponse::clear() { result = StartFailed; @@ -263,11 +257,11 @@ void ChannelBuffer::append(const QByteArray &text, bool emitSignals) } // ----------- SynchronousProcessPrivate -struct SynchronousProcessPrivate { - SynchronousProcessPrivate(); +class SynchronousProcessPrivate { +public: void clearForRun(); - QTextCodec *m_codec; + QTextCodec *m_codec = QTextCodec::codecForLocale(); TerminalControllingProcess m_process; QTimer m_timer; QEventLoop m_eventLoop; @@ -284,11 +278,6 @@ struct SynchronousProcessPrivate { bool m_waitingForUser = false; }; -SynchronousProcessPrivate::SynchronousProcessPrivate() : - m_codec(QTextCodec::codecForLocale()) -{ -} - void SynchronousProcessPrivate::clearForRun() { m_hangTimerCount = 0; |