diff options
| author | hjk <hjk@qt.io> | 2019-07-23 10:17:57 +0200 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2019-07-23 15:51:45 +0000 |
| commit | 8b72e9216746c04e68a1c6498ac3396942fbebce (patch) | |
| tree | c8742f1cf932ec3fae5a3f6476b390dbeb06ec9e /src/libs/extensionsystem | |
| parent | 80716610c5f4deb32af15f1189363bf2ebffa41e (diff) | |
| download | qt-creator-8b72e9216746c04e68a1c6498ac3396942fbebce.tar.gz | |
Utils: Add CommandLine convenience constructors
... taking a QString for the executable.
This weakens the very explicit QString -> FileName conversion via the
named constructors for the special case of constructing a CommandLine.
I think that's worthwhile here, as it reduces the noise on the caller
site under circumstance where the nature of the thing is obvious.
Change-Id: I27b4a73639728893d053b2e7ba65cb745f0ffe83
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/libs/extensionsystem')
| -rw-r--r-- | src/libs/extensionsystem/pluginmanager.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/libs/extensionsystem/pluginmanager.cpp b/src/libs/extensionsystem/pluginmanager.cpp index 9ef7d8cdc7..3e99abe11e 100644 --- a/src/libs/extensionsystem/pluginmanager.cpp +++ b/src/libs/extensionsystem/pluginmanager.cpp @@ -414,8 +414,8 @@ static QString filled(const QString &s, int min) QString PluginManager::systemInformation() const { QString result; - CommandLine qtDiag(FilePath::fromString(HostOsInfo::withExecutableSuffix( - QLibraryInfo::location(QLibraryInfo::BinariesPath) + "/qtdiag"))); + CommandLine qtDiag(HostOsInfo::withExecutableSuffix( + QLibraryInfo::location(QLibraryInfo::BinariesPath) + "/qtdiag")); SynchronousProcess qtdiagProc; const SynchronousProcessResponse response = qtdiagProc.runBlocking(qtDiag); if (response.result == SynchronousProcessResponse::Finished) |