QmlJS: Disable collection of semantic messages in 'Build Issues'.

There are too many false positives when a project contains source code
for plugins and qml files using that plugin at the same time. It was
particularly bad for qtdeclarative itself.

Reviewed-by: Roberto Raggi

1 files changed, 10 insertions, 8 deletions

diff --git a/src/plugins/qmljseditor/qmltaskmanager.cpp b/src/plugins/qmljseditor/qmltaskmanager.cpp
index 3bcb5d12a2..2fdc44f806 100644
--- a/src/plugins/qmljseditor/qmltaskmanager.cpp
+++ b/src/plugins/qmljseditor/qmltaskmanager.cpp
@@ -70,12 +70,13 @@ QmlTaskManager::QmlTaskManager(QObject *parent) :
 }
 
 void QmlTaskManager::collectMessages(QFutureInterface<FileErrorMessages> &future,
-    Snapshot snapshot, QStringList files, QStringList importPaths)
+    Snapshot snapshot, QStringList files, QStringList /*importPaths*/)
 {
-    Interpreter::Context ctx(snapshot);
-    QHash<QString, QList<DiagnosticMessage> > linkMessages;
-    Link link(&ctx, snapshot, importPaths);
-    link(&linkMessages);
+    // ### link and check error messages are disabled for now: too many false-positives!
+    //Interpreter::Context ctx(snapshot);
+    //QHash<QString, QList<DiagnosticMessage> > linkMessages;
+    //Link link(&ctx, snapshot, importPaths);
+    //link(&linkMessages);
 
     foreach (const QString &fileName, files) {
         Document::Ptr document = snapshot.document(fileName);
@@ -85,10 +86,11 @@ void QmlTaskManager::collectMessages(QFutureInterface<FileErrorMessages> &future
         FileErrorMessages result;
         result.fileName = fileName;
         result.messages = document->diagnosticMessages();
-        result.messages += linkMessages.value(fileName);
 
-        Check checker(document, &ctx);
-        result.messages.append(checker());
+        //result.messages += linkMessages.value(fileName);
+
+        //Check checker(document, &ctx);
+        //result.messages.append(checker());
 
         future.reportResult(result);
         if (future.isCanceled())