diff options
author | Marcus Tillmanns <marcus.tillmanns@qt.io> | 2023-05-17 10:30:20 +0200 |
---|---|---|
committer | Marcus Tillmanns <marcus.tillmanns@qt.io> | 2023-05-17 08:31:41 +0000 |
commit | c59f3102a1a772da33022ca490a32d390ae827a3 (patch) | |
tree | acb29dc360220e10db28cbe1aacd7d0c61135259 | |
parent | 8f5703a7b9c5b4a272b44c85aa428dd3992bb13d (diff) | |
download | qt-creator-c59f3102a1a772da33022ca490a32d390ae827a3.tar.gz |
CrashHandler: Fix missing update
The change to CheckableMessageBox was missed.
Change-Id: I8b7fe1230bcf483f9e5371b878d862aff422d925
Reviewed-by: hjk <hjk@qt.io>
-rw-r--r-- | src/tools/qtcreatorcrashhandler/crashhandlerdialog.cpp | 27 |
1 files changed, 14 insertions, 13 deletions
diff --git a/src/tools/qtcreatorcrashhandler/crashhandlerdialog.cpp b/src/tools/qtcreatorcrashhandler/crashhandlerdialog.cpp index acbc3fa28f..61d1fd4230 100644 --- a/src/tools/qtcreatorcrashhandler/crashhandlerdialog.cpp +++ b/src/tools/qtcreatorcrashhandler/crashhandlerdialog.cpp @@ -205,12 +205,10 @@ CrashHandlerDialog::~CrashHandlerDialog() bool CrashHandlerDialog::runDebuggerWhileBacktraceNotFinished() { // Check settings. - QSettings settings(QSettings::IniFormat, QSettings::UserScope, + QSettings settings(QSettings::IniFormat, + QSettings::UserScope, QLatin1String(Core::Constants::IDE_SETTINGSVARIANT_STR), QLatin1String(SettingsApplication)); - if (settings.value(QLatin1String(SettingsKeySkipWarningAbortingBacktrace), false).toBool()) - return true; - // Ask user. const QString title = tr("Run Debugger And Abort Collecting Backtrace?"); const QString message = tr( @@ -219,15 +217,18 @@ bool CrashHandlerDialog::runDebuggerWhileBacktraceNotFinished() "<p>You have requested to run the debugger while collecting the backtrace was not " "finished.</p>" "</body></html>"); - const QString checkBoxText = tr("Do not &ask again."); - bool checkBoxSetting = false; - const QDialogButtonBox::StandardButton button = Utils::CheckableMessageBox::question(this, - title, message, checkBoxText, &checkBoxSetting, - QDialogButtonBox::Yes | QDialogButtonBox::No, QDialogButtonBox::No); - if (checkBoxSetting) - settings.setValue(QLatin1String(SettingsKeySkipWarningAbortingBacktrace), checkBoxSetting); - - return button == QDialogButtonBox::Yes; + + const QMessageBox::StandardButton button + = Utils::CheckableMessageBox::question(this, + title, + message, + &settings, + QLatin1String( + SettingsKeySkipWarningAbortingBacktrace), + QMessageBox::Yes | QMessageBox::No, + QMessageBox::No); + + return button == QMessageBox::Yes; } void CrashHandlerDialog::setToFinalState() |