summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Hartmann <thomas.hartmann@qt.io>2018-08-01 13:45:49 +0200
committerThomas Hartmann <thomas.hartmann@qt.io>2018-08-08 05:48:39 +0000
commit6655f3725919990ccb90c5bebae2476200d56a47 (patch)
treea71f0d94409474b9f7d28b74c75e17d17968cbd1
parent847787f146b2583167f9d4bdbfb912c075b4af15 (diff)
downloadqt-creator-6655f3725919990ccb90c5bebae2476200d56a47.tar.gz
QmlDesigner: Fix clazy warning
Remove superfluous call to default constructors. Change-Id: Id16d7641a28b1d4b58c8bfe26b7076e8122b72c3 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
-rw-r--r--src/plugins/qmldesigner/components/formeditor/formeditorwidget.cpp3
-rw-r--r--src/plugins/qmldesigner/components/formeditor/layeritem.cpp1
-rw-r--r--src/plugins/qmldesigner/components/navigator/navigatorwidget.cpp7
-rw-r--r--src/plugins/qmldesigner/components/stateseditor/stateseditorwidget.cpp7
-rw-r--r--src/plugins/qmldesigner/designercore/model/qmlobjectnode.cpp1
-rw-r--r--src/plugins/qmldesigner/designercore/model/qmlstate.cpp1
-rw-r--r--src/plugins/qmldesigner/qmldesignerextension/colortool/colortool.cpp1
-rw-r--r--src/plugins/qmldesigner/qmldesignerextension/pathtool/pathitem.cpp9
-rw-r--r--src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtool.cpp4
-rw-r--r--src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtoolview.cpp3
-rw-r--r--src/plugins/qmldesigner/qmldesignerextension/sourcetool/sourcetool.cpp2
-rw-r--r--src/plugins/qmldesigner/qmldesignerextension/texttool/textedititemwidget.cpp1
-rw-r--r--src/plugins/qmldesigner/qmldesignerextension/texttool/texttool.cpp1
13 files changed, 13 insertions, 28 deletions
diff --git a/src/plugins/qmldesigner/components/formeditor/formeditorwidget.cpp b/src/plugins/qmldesigner/components/formeditor/formeditorwidget.cpp
index 4bc952dd8c..954f8fee66 100644
--- a/src/plugins/qmldesigner/components/formeditor/formeditorwidget.cpp
+++ b/src/plugins/qmldesigner/components/formeditor/formeditorwidget.cpp
@@ -55,8 +55,7 @@
namespace QmlDesigner {
-FormEditorWidget::FormEditorWidget(FormEditorView *view)
- : QWidget(),
+FormEditorWidget::FormEditorWidget(FormEditorView *view) :
m_formEditorView(view)
{
setStyleSheet(Theme::replaceCssColors(QString::fromUtf8(Utils::FileReader::fetchQrc(QLatin1String(":/qmldesigner/formeditorstylesheet.css")))));
diff --git a/src/plugins/qmldesigner/components/formeditor/layeritem.cpp b/src/plugins/qmldesigner/components/formeditor/layeritem.cpp
index fc56379f31..993e6c382c 100644
--- a/src/plugins/qmldesigner/components/formeditor/layeritem.cpp
+++ b/src/plugins/qmldesigner/components/formeditor/layeritem.cpp
@@ -31,7 +31,6 @@
namespace QmlDesigner {
LayerItem::LayerItem(FormEditorScene* scene)
- : QGraphicsObject()
{
scene->addItem(this);
setZValue(1);
diff --git a/src/plugins/qmldesigner/components/navigator/navigatorwidget.cpp b/src/plugins/qmldesigner/components/navigator/navigatorwidget.cpp
index 43f13c2bf3..17f8650950 100644
--- a/src/plugins/qmldesigner/components/navigator/navigatorwidget.cpp
+++ b/src/plugins/qmldesigner/components/navigator/navigatorwidget.cpp
@@ -45,10 +45,9 @@
namespace QmlDesigner {
-NavigatorWidget::NavigatorWidget(NavigatorView *view) :
- QFrame(),
- m_treeView(new NavigatorTreeView),
- m_navigatorView(view)
+NavigatorWidget::NavigatorWidget(NavigatorView *view)
+ : m_treeView(new NavigatorTreeView),
+ m_navigatorView(view)
{
m_treeView->setDragEnabled(true);
m_treeView->setAcceptDrops(true);
diff --git a/src/plugins/qmldesigner/components/stateseditor/stateseditorwidget.cpp b/src/plugins/qmldesigner/components/stateseditor/stateseditorwidget.cpp
index 7b6358f251..956b0d32a6 100644
--- a/src/plugins/qmldesigner/components/stateseditor/stateseditorwidget.cpp
+++ b/src/plugins/qmldesigner/components/stateseditor/stateseditorwidget.cpp
@@ -85,10 +85,9 @@ void StatesEditorWidget::showAddNewStatesButton(bool showAddNewStatesButton)
}
StatesEditorWidget::StatesEditorWidget(StatesEditorView *statesEditorView, StatesEditorModel *statesEditorModel)
- : QQuickWidget(),
- m_statesEditorView(statesEditorView),
- m_imageProvider(nullptr),
- m_qmlSourceUpdateShortcut(nullptr)
+ : m_statesEditorView(statesEditorView),
+ m_imageProvider(nullptr),
+ m_qmlSourceUpdateShortcut(nullptr)
{
m_imageProvider = new Internal::StatesEditorImageProvider;
m_imageProvider->setNodeInstanceView(statesEditorView->nodeInstanceView());
diff --git a/src/plugins/qmldesigner/designercore/model/qmlobjectnode.cpp b/src/plugins/qmldesigner/designercore/model/qmlobjectnode.cpp
index 6d598350f7..650d1e7305 100644
--- a/src/plugins/qmldesigner/designercore/model/qmlobjectnode.cpp
+++ b/src/plugins/qmldesigner/designercore/model/qmlobjectnode.cpp
@@ -568,7 +568,6 @@ QmlItemNode QmlObjectNode::itemForInstance(const NodeInstance &instance) const
}
QmlObjectNode::QmlObjectNode()
- : QmlModelNodeFacade()
{
}
diff --git a/src/plugins/qmldesigner/designercore/model/qmlstate.cpp b/src/plugins/qmldesigner/designercore/model/qmlstate.cpp
index c937d446d6..adb56076eb 100644
--- a/src/plugins/qmldesigner/designercore/model/qmlstate.cpp
+++ b/src/plugins/qmldesigner/designercore/model/qmlstate.cpp
@@ -38,7 +38,6 @@
namespace QmlDesigner {
QmlModelState::QmlModelState()
- : QmlModelNodeFacade()
{
}
diff --git a/src/plugins/qmldesigner/qmldesignerextension/colortool/colortool.cpp b/src/plugins/qmldesigner/qmldesignerextension/colortool/colortool.cpp
index 283cdb901d..32a5742f9f 100644
--- a/src/plugins/qmldesigner/qmldesignerextension/colortool/colortool.cpp
+++ b/src/plugins/qmldesigner/qmldesignerextension/colortool/colortool.cpp
@@ -89,7 +89,6 @@ protected:
};
ColorTool::ColorTool()
- : QObject(), AbstractCustomTool()
{
auto colorToolAction = new ColorToolAction;
QmlDesignerPlugin::instance()->designerActionManager().addDesignerAction(colorToolAction);
diff --git a/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathitem.cpp b/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathitem.cpp
index 6d858a86de..0d5b380747 100644
--- a/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathitem.cpp
+++ b/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathitem.cpp
@@ -42,11 +42,10 @@
namespace QmlDesigner {
PathItem::PathItem(FormEditorScene* scene)
- : QGraphicsObject(),
- m_selectionManipulator(this),
- m_lastPercent(-1.),
- m_formEditorItem(nullptr),
- m_dontUpdatePath(false)
+ : m_selectionManipulator(this),
+ m_lastPercent(-1.),
+ m_formEditorItem(nullptr),
+ m_dontUpdatePath(false)
{
scene->addItem(this);
setFlag(QGraphicsItem::ItemIsMovable, false);
diff --git a/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtool.cpp b/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtool.cpp
index 6873c8e62c..a01ae050ac 100644
--- a/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtool.cpp
+++ b/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtool.cpp
@@ -140,9 +140,7 @@ protected:
};
PathTool::PathTool()
- : QObject(),
- AbstractCustomTool(),
- m_pathToolView(this)
+ : m_pathToolView(this)
{
auto textToolAction = new PathToolAction;
QmlDesignerPlugin::instance()->designerActionManager().addDesignerAction(textToolAction);
diff --git a/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtoolview.cpp b/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtoolview.cpp
index a15abf569e..ea1e28832a 100644
--- a/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtoolview.cpp
+++ b/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtoolview.cpp
@@ -37,8 +37,7 @@
namespace QmlDesigner {
PathToolView::PathToolView(PathTool *pathTool)
- : AbstractView(),
- m_pathTool(pathTool)
+ : m_pathTool(pathTool)
{
}
diff --git a/src/plugins/qmldesigner/qmldesignerextension/sourcetool/sourcetool.cpp b/src/plugins/qmldesigner/qmldesignerextension/sourcetool/sourcetool.cpp
index 0dad29f3c2..d121e60c73 100644
--- a/src/plugins/qmldesigner/qmldesignerextension/sourcetool/sourcetool.cpp
+++ b/src/plugins/qmldesigner/qmldesignerextension/sourcetool/sourcetool.cpp
@@ -115,7 +115,6 @@ protected:
SourceTool::SourceTool()
- : QObject(), AbstractCustomTool()
{
auto sourceToolAction = new SourceToolAction;
QmlDesignerPlugin::instance()->designerActionManager().addDesignerAction(sourceToolAction);
@@ -169,7 +168,6 @@ void SourceTool::mouseReleaseEvent(const QList<QGraphicsItem*> &itemList,
AbstractFormEditorTool::mouseReleaseEvent(itemList, event);
}
-
void SourceTool::mouseDoubleClickEvent(const QList<QGraphicsItem*> &itemList, QGraphicsSceneMouseEvent *event)
{
AbstractFormEditorTool::mouseDoubleClickEvent(itemList, event);
diff --git a/src/plugins/qmldesigner/qmldesignerextension/texttool/textedititemwidget.cpp b/src/plugins/qmldesigner/qmldesignerextension/texttool/textedititemwidget.cpp
index 750589aa9a..40efb67e77 100644
--- a/src/plugins/qmldesigner/qmldesignerextension/texttool/textedititemwidget.cpp
+++ b/src/plugins/qmldesigner/qmldesignerextension/texttool/textedititemwidget.cpp
@@ -34,7 +34,6 @@
namespace QmlDesigner {
TextEditItemWidget::TextEditItemWidget(QGraphicsScene* scene)
- : QGraphicsProxyWidget()
{
scene->addItem(this);
setFlag(QGraphicsItem::ItemIsMovable, false);
diff --git a/src/plugins/qmldesigner/qmldesignerextension/texttool/texttool.cpp b/src/plugins/qmldesigner/qmldesignerextension/texttool/texttool.cpp
index 1d22f2f876..76dc414c03 100644
--- a/src/plugins/qmldesigner/qmldesignerextension/texttool/texttool.cpp
+++ b/src/plugins/qmldesigner/qmldesignerextension/texttool/texttool.cpp
@@ -93,7 +93,6 @@ protected:
};
TextTool::TextTool()
- : QObject() , AbstractCustomTool()
{
auto textToolAction = new TextToolAction;
QmlDesignerPlugin::instance()->designerActionManager().addDesignerAction(textToolAction);