diff options
| author | Orgad Shaneh <orgad.shaneh@audiocodes.com> | 2014-05-05 17:12:10 +0300 |
|---|---|---|
| committer | Orgad Shaneh <orgads@gmail.com> | 2014-05-06 15:32:52 +0200 |
| commit | 642706dc44b493018f643975856ae901ac505735 (patch) | |
| tree | b9428ffd69a0c2a9b14fdd4f588cad770c05654a | |
| parent | b3ff928b0a666c8b6743aebed4d982a0b7a3b3b7 (diff) | |
| download | qt-creator-642706dc44b493018f643975856ae901ac505735.tar.gz | |
VCS: Pass const values by references
Change-Id: I9749c0c76b810f3d5fee1aa8c5750dac5930cd3c
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
| -rw-r--r-- | src/plugins/git/branchmodel.cpp | 2 | ||||
| -rw-r--r-- | src/plugins/git/gitclient.cpp | 6 | ||||
| -rw-r--r-- | src/plugins/git/gitclient.h | 2 | ||||
| -rw-r--r-- | src/plugins/perforce/perforceplugin.cpp | 9 | ||||
| -rw-r--r-- | src/plugins/perforce/perforceplugin.h | 2 |
5 files changed, 11 insertions, 10 deletions
diff --git a/src/plugins/git/branchmodel.cpp b/src/plugins/git/branchmodel.cpp index 93cce7de06..33db39455b 100644 --- a/src/plugins/git/branchmodel.cpp +++ b/src/plugins/git/branchmodel.cpp @@ -141,7 +141,7 @@ public: return fn; } - void insert(const QStringList path, BranchNode *n) + void insert(const QStringList &path, BranchNode *n) { BranchNode *current = this; for (int i = 0; i < path.count(); ++i) { diff --git a/src/plugins/git/gitclient.cpp b/src/plugins/git/gitclient.cpp index 1f7864b544..7e48fbaf63 100644 --- a/src/plugins/git/gitclient.cpp +++ b/src/plugins/git/gitclient.cpp @@ -1096,9 +1096,9 @@ VcsBase::VcsBaseEditorWidget *GitClient::findExistingVCSEditor(const char *regis return rc; } -DiffEditor::DiffEditorDocument *GitClient::createDiffEditor(const QString documentId, - const QString &source, - const QString &title) const +DiffEditor::DiffEditorDocument *GitClient::createDiffEditor(const QString &documentId, + const QString &source, + const QString &title) const { DiffEditor::DiffEditorDocument *diffEditorDocument = DiffEditor::DiffEditorManager::findOrCreate(documentId, title); QTC_ASSERT(diffEditorDocument, return 0); diff --git a/src/plugins/git/gitclient.h b/src/plugins/git/gitclient.h index c95e7fef18..85d50c796c 100644 --- a/src/plugins/git/gitclient.h +++ b/src/plugins/git/gitclient.h @@ -356,7 +356,7 @@ private: const char *registerDynamicProperty, const QString &dynamicPropertyValue, VcsBase::VcsBaseEditorParameterWidget *configWidget) const; - DiffEditor::DiffEditorDocument *createDiffEditor(const QString documentId, + DiffEditor::DiffEditorDocument *createDiffEditor(const QString &documentId, const QString &source, const QString &title) const; diff --git a/src/plugins/perforce/perforceplugin.cpp b/src/plugins/perforce/perforceplugin.cpp index 93483e5450..7aa66aee03 100644 --- a/src/plugins/perforce/perforceplugin.cpp +++ b/src/plugins/perforce/perforceplugin.cpp @@ -1169,10 +1169,11 @@ PerforceResponse PerforcePlugin::runP4Cmd(const QString &workingDir, return response; } -Core::IEditor *PerforcePlugin::showOutputInEditor(const QString &title, const QString output, - int editorType, - const QString &source, - QTextCodec *codec) +Core::IEditor *PerforcePlugin::showOutputInEditor(const QString &title, + const QString &output, + int editorType, + const QString &source, + QTextCodec *codec) { const VcsBase::VcsBaseEditorParameters *params = findType(editorType); QTC_ASSERT(params, return 0); diff --git a/src/plugins/perforce/perforceplugin.h b/src/plugins/perforce/perforceplugin.h index bcee48574e..4bc98b8cfb 100644 --- a/src/plugins/perforce/perforceplugin.h +++ b/src/plugins/perforce/perforceplugin.h @@ -146,7 +146,7 @@ protected: private: typedef QHash<QString, bool> ManagedDirectoryCache; - Core::IEditor *showOutputInEditor(const QString& title, const QString output, + Core::IEditor *showOutputInEditor(const QString &title, const QString &output, int editorType, const QString &source, QTextCodec *codec = 0); |