diff options
| author | Eike Ziller <eike.ziller@digia.com> | 2013-10-27 10:47:46 +0100 |
|---|---|---|
| committer | Eike Ziller <eike.ziller@digia.com> | 2013-10-28 08:32:26 +0100 |
| commit | 0979e75a3aa2dd2339da57eec52db47ff0910213 (patch) | |
| tree | c4435c80949b827d2fee4f23ab7a4c853f21e8b3 | |
| parent | 903b06ec0e88957a04f5f453fa0e75bbbf2740ef (diff) | |
| download | qt-creator-0979e75a3aa2dd2339da57eec52db47ff0910213.tar.gz | |
debugger: generalize is32bit() through ptrSize()
That also makes lldb dumper actually test for bitness instead of
assuming 64bit
Change-Id: I6207bac04817e1f4700247dc00d2dfdace1e5100
| -rw-r--r-- | share/qtcreator/debugger/dumper.py | 3 | ||||
| -rw-r--r-- | share/qtcreator/debugger/gdbbridge.py | 3 | ||||
| -rw-r--r-- | share/qtcreator/debugger/lldbbridge.py | 3 |
3 files changed, 3 insertions, 6 deletions
diff --git a/share/qtcreator/debugger/dumper.py b/share/qtcreator/debugger/dumper.py index cf37f4f965..a0b1028ff4 100644 --- a/share/qtcreator/debugger/dumper.py +++ b/share/qtcreator/debugger/dumper.py @@ -261,6 +261,9 @@ class DumperBase: self.isGdb = False self.isLldb = False + def is32bit(self): + return self.ptrSize() == 4 + def computeLimit(self, size, limit): if limit is None: return size diff --git a/share/qtcreator/debugger/gdbbridge.py b/share/qtcreator/debugger/gdbbridge.py index 2d0df4275a..ae096c907b 100644 --- a/share/qtcreator/debugger/gdbbridge.py +++ b/share/qtcreator/debugger/gdbbridge.py @@ -1230,9 +1230,6 @@ class Dumper(DumperBase): def ptrSize(self): return self.lookupType('void*').sizeof - def is32bit(self): - return self.lookupType('void*').sizeof == 4 - def createValue(self, address, referencedType): try: return gdb.Value(address).cast(referencedType.pointer()).dereference() diff --git a/share/qtcreator/debugger/lldbbridge.py b/share/qtcreator/debugger/lldbbridge.py index 4a465c981f..c347c4ea09 100644 --- a/share/qtcreator/debugger/lldbbridge.py +++ b/share/qtcreator/debugger/lldbbridge.py @@ -494,9 +494,6 @@ class Dumper(DumperBase): break return qqVersion - def is32bit(self): - return False - def intSize(self): return 4 |