From 0979e75a3aa2dd2339da57eec52db47ff0910213 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Sun, 27 Oct 2013 10:47:46 +0100 Subject: debugger: generalize is32bit() through ptrSize() That also makes lldb dumper actually test for bitness instead of assuming 64bit Change-Id: I6207bac04817e1f4700247dc00d2dfdace1e5100 --- share/qtcreator/debugger/dumper.py | 3 +++ share/qtcreator/debugger/gdbbridge.py | 3 --- share/qtcreator/debugger/lldbbridge.py | 3 --- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/share/qtcreator/debugger/dumper.py b/share/qtcreator/debugger/dumper.py index cf37f4f965..a0b1028ff4 100644 --- a/share/qtcreator/debugger/dumper.py +++ b/share/qtcreator/debugger/dumper.py @@ -261,6 +261,9 @@ class DumperBase: self.isGdb = False self.isLldb = False + def is32bit(self): + return self.ptrSize() == 4 + def computeLimit(self, size, limit): if limit is None: return size diff --git a/share/qtcreator/debugger/gdbbridge.py b/share/qtcreator/debugger/gdbbridge.py index 2d0df4275a..ae096c907b 100644 --- a/share/qtcreator/debugger/gdbbridge.py +++ b/share/qtcreator/debugger/gdbbridge.py @@ -1230,9 +1230,6 @@ class Dumper(DumperBase): def ptrSize(self): return self.lookupType('void*').sizeof - def is32bit(self): - return self.lookupType('void*').sizeof == 4 - def createValue(self, address, referencedType): try: return gdb.Value(address).cast(referencedType.pointer()).dereference() diff --git a/share/qtcreator/debugger/lldbbridge.py b/share/qtcreator/debugger/lldbbridge.py index 4a465c981f..c347c4ea09 100644 --- a/share/qtcreator/debugger/lldbbridge.py +++ b/share/qtcreator/debugger/lldbbridge.py @@ -494,9 +494,6 @@ class Dumper(DumperBase): break return qqVersion - def is32bit(self): - return False - def intSize(self): return 4 -- cgit v1.2.1