diff options
| author | Aurindam Jana <aurindam.jana@digia.com> | 2013-01-16 15:13:47 +0100 |
|---|---|---|
| committer | Tobias Hunger <tobias.hunger@digia.com> | 2013-01-16 15:21:39 +0100 |
| commit | b437b988e504b20440f1fdf7ef72157a5e616ae3 (patch) | |
| tree | 8812bb42dcdb6a89c1002ceba4cb303a597ab768 | |
| parent | f841f3743d990921b15f7bc87d492056c8912d0d (diff) | |
| download | qt-creator-b437b988e504b20440f1fdf7ef72157a5e616ae3.tar.gz | |
KitManager: Scope KitGuard
Scope KitGuard correctly to avoid emitting kitUpdated signal
when adding a kit.
Change-Id: Id9b0f92c7c2be8adaf7490cfbecfaceb8717b80f
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
| -rw-r--r-- | src/plugins/projectexplorer/kitmanager.cpp | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/src/plugins/projectexplorer/kitmanager.cpp b/src/plugins/projectexplorer/kitmanager.cpp index e8486709bb..1daf495349 100644 --- a/src/plugins/projectexplorer/kitmanager.cpp +++ b/src/plugins/projectexplorer/kitmanager.cpp @@ -446,12 +446,14 @@ void KitManager::addKit(Kit *k) if (!k) return; - KitGuard g(k); - foreach (KitInformation *ki, d->m_informationList) { - if (!k->hasValue(ki->dataId())) - k->setValue(ki->dataId(), ki->defaultValue(k)); - else - ki->fix(k); + { + KitGuard g(k); + foreach (KitInformation *ki, d->m_informationList) { + if (!k->hasValue(ki->dataId())) + k->setValue(ki->dataId(), ki->defaultValue(k)); + else + ki->fix(k); + } } d->m_kitList.append(k); |