From b437b988e504b20440f1fdf7ef72157a5e616ae3 Mon Sep 17 00:00:00 2001 From: Aurindam Jana Date: Wed, 16 Jan 2013 15:13:47 +0100 Subject: KitManager: Scope KitGuard Scope KitGuard correctly to avoid emitting kitUpdated signal when adding a kit. Change-Id: Id9b0f92c7c2be8adaf7490cfbecfaceb8717b80f Reviewed-by: Tobias Hunger --- src/plugins/projectexplorer/kitmanager.cpp | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/plugins/projectexplorer/kitmanager.cpp b/src/plugins/projectexplorer/kitmanager.cpp index e8486709bb..1daf495349 100644 --- a/src/plugins/projectexplorer/kitmanager.cpp +++ b/src/plugins/projectexplorer/kitmanager.cpp @@ -446,12 +446,14 @@ void KitManager::addKit(Kit *k) if (!k) return; - KitGuard g(k); - foreach (KitInformation *ki, d->m_informationList) { - if (!k->hasValue(ki->dataId())) - k->setValue(ki->dataId(), ki->defaultValue(k)); - else - ki->fix(k); + { + KitGuard g(k); + foreach (KitInformation *ki, d->m_informationList) { + if (!k->hasValue(ki->dataId())) + k->setValue(ki->dataId(), ki->defaultValue(k)); + else + ki->fix(k); + } } d->m_kitList.append(k); -- cgit v1.2.1