diff options
| author | Dmitry Stogov <dmitry@zend.com> | 2018-01-17 02:25:36 +0300 |
|---|---|---|
| committer | Dmitry Stogov <dmitry@zend.com> | 2018-01-17 02:25:36 +0300 |
| commit | ecd2624875af4b943f6817e0f63ee7d2c9192c5e (patch) | |
| tree | ba38d3a3faaa593081d033463331b851e16c893d /ext/intl/msgformat/msgformat_format.c | |
| parent | 5c77bac9a74de2e1a16bae22a6f338380f5dc202 (diff) | |
| download | php-git-ecd2624875af4b943f6817e0f63ee7d2c9192c5e.tar.gz | |
Avoid array duplication and in-place modification
Diffstat (limited to 'ext/intl/msgformat/msgformat_format.c')
| -rw-r--r-- | ext/intl/msgformat/msgformat_format.c | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/ext/intl/msgformat/msgformat_format.c b/ext/intl/msgformat/msgformat_format.c index bfc9dbe3ac..f421991643 100644 --- a/ext/intl/msgformat/msgformat_format.c +++ b/ext/intl/msgformat/msgformat_format.c @@ -37,17 +37,8 @@ static void msgfmt_do_format(MessageFormatter_object *mfo, zval *args, zval *ret int count; UChar* formatted = NULL; int32_t formatted_len = 0; - HashTable *args_copy; - count = zend_hash_num_elements(Z_ARRVAL_P(args)); - - args_copy = zend_new_array(count); - zend_hash_copy(args_copy, Z_ARRVAL_P(args), (copy_ctor_func_t)zval_add_ref); - - umsg_format_helper(mfo, args_copy, &formatted, &formatted_len); - - zend_hash_destroy(args_copy); - efree(args_copy); + umsg_format_helper(mfo, Z_ARRVAL_P(args), &formatted, &formatted_len); if (U_FAILURE(INTL_DATA_ERROR_CODE(mfo))) { if (formatted) { |