From ecd2624875af4b943f6817e0f63ee7d2c9192c5e Mon Sep 17 00:00:00 2001 From: Dmitry Stogov Date: Wed, 17 Jan 2018 02:25:36 +0300 Subject: Avoid array duplication and in-place modification --- ext/intl/msgformat/msgformat_format.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) (limited to 'ext/intl/msgformat/msgformat_format.c') diff --git a/ext/intl/msgformat/msgformat_format.c b/ext/intl/msgformat/msgformat_format.c index bfc9dbe3ac..f421991643 100644 --- a/ext/intl/msgformat/msgformat_format.c +++ b/ext/intl/msgformat/msgformat_format.c @@ -37,17 +37,8 @@ static void msgfmt_do_format(MessageFormatter_object *mfo, zval *args, zval *ret int count; UChar* formatted = NULL; int32_t formatted_len = 0; - HashTable *args_copy; - count = zend_hash_num_elements(Z_ARRVAL_P(args)); - - args_copy = zend_new_array(count); - zend_hash_copy(args_copy, Z_ARRVAL_P(args), (copy_ctor_func_t)zval_add_ref); - - umsg_format_helper(mfo, args_copy, &formatted, &formatted_len); - - zend_hash_destroy(args_copy); - efree(args_copy); + umsg_format_helper(mfo, Z_ARRVAL_P(args), &formatted, &formatted_len); if (U_FAILURE(INTL_DATA_ERROR_CODE(mfo))) { if (formatted) { -- cgit v1.2.1