summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacob Garber <jgarber1@ualberta.ca>2019-07-17 17:07:48 -0600
committerStephen Warren <swarren@nvidia.com>2019-07-17 17:47:14 -0600
commit65a6d94dd5f442578551e0a81ecbe5235e673fd4 (patch)
tree97152618f354329e4d8020cb4e66b4e5b76afd1f
parent9de64c77f0567ac3fbcc4ce62a7090a6bae84360 (diff)
downloadcbootimage-65a6d94dd5f442578551e0a81ecbe5235e673fd4.tar.gz
Free image buffer on read error
Free the buffer after a read error to prevent a memory leak. This was flagged by a Coverity scan of the coreboot project, which uses cbootimage. Signed-off-by: Jacob Garber <jgarber1@ualberta.ca> Signed-off-by: Stephen Warren <swarren@nvidia.com>
-rw-r--r--src/set.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/set.c b/src/set.c
index 934a58d..2013169 100644
--- a/src/set.c
+++ b/src/set.c
@@ -98,6 +98,7 @@ read_from_image(char *filename,
if (fread(*image, 1, (size_t)(*actual_size), fp) !=
(size_t)(*actual_size)) {
result = 1;
+ free(*image);
goto cleanup;
}