From 65a6d94dd5f442578551e0a81ecbe5235e673fd4 Mon Sep 17 00:00:00 2001 From: Jacob Garber Date: Wed, 17 Jul 2019 17:07:48 -0600 Subject: Free image buffer on read error Free the buffer after a read error to prevent a memory leak. This was flagged by a Coverity scan of the coreboot project, which uses cbootimage. Signed-off-by: Jacob Garber Signed-off-by: Stephen Warren --- src/set.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/set.c b/src/set.c index 934a58d..2013169 100644 --- a/src/set.c +++ b/src/set.c @@ -98,6 +98,7 @@ read_from_image(char *filename, if (fread(*image, 1, (size_t)(*actual_size), fp) != (size_t)(*actual_size)) { result = 1; + free(*image); goto cleanup; } -- cgit v1.2.1