summaryrefslogtreecommitdiff
path: root/src/imagination/vulkan/pvr_job_transfer.c
diff options
context:
space:
mode:
authorKarmjit Mahil <Karmjit.Mahil@imgtec.com>2023-05-04 15:25:40 +0100
committerMarge Bot <emma+marge@anholt.net>2023-05-16 18:09:03 +0000
commit48bf9c736f92e22791e24f1c202020179ff7e790 (patch)
tree05d02c1da57fc045b5d72054b900e360f0b6f939 /src/imagination/vulkan/pvr_job_transfer.c
parentbac048e1dfed0ddfa7d95e55565d0ac486997b9b (diff)
downloadmesa-48bf9c736f92e22791e24f1c202020179ff7e790.tar.gz
pvr: Use original binding numbers instead of reassigning
Previously, in the descriptor set layout, if there were gaps within the binding numbers, the code would remove the gap and assign a sequential binding number to each. This is causes problems when looking up the binding on a vkUpdateDescriptorSets() as the user would still be providing the original binding numbers. If gaps were removed and binding number re-assigned, the binding could either not be found, or a different binding was found instead of the desired one. Let's not re-assign binding numbers and just use the original ones. This fixes the following assert being hit: `pvr_descriptor_set.c:1890: pvr_write_descriptor_set: Assertion `binding' failed.` on dEQP tests such as: dEQP-VK.glsl.opaque_type_indexing.ubo.uniform_vertex dEQP-VK.glsl.opaque_type_indexing.ubo.uniform_fragment ... Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com> Reviewed-by: Frank Binns <frank.binns@imgtec.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22918>
Diffstat (limited to 'src/imagination/vulkan/pvr_job_transfer.c')
0 files changed, 0 insertions, 0 deletions