diff options
| author | Eric Anholt <eric@anholt.net> | 2020-07-20 11:21:36 -0700 |
|---|---|---|
| committer | Marge Bot <eric+marge@anholt.net> | 2020-07-30 19:59:20 +0000 |
| commit | 75b1f3d39df4f098b3674adee52a9db41c1fa96a (patch) | |
| tree | 85ac37b47a4dd51198c2f467c10ff6a21b5fdd55 /src/drm-shim | |
| parent | c77a414ec2d3cfde3783300afcf59e4f87826b82 (diff) | |
| download | mesa-75b1f3d39df4f098b3674adee52a9db41c1fa96a.tar.gz | |
drm-shim: Return -EINVAL instead of abort()ing on unknown ioctls.
I had this as abort() in my original implementation since I was doing
drm-shim and my kernel driver in parallel based around using a SW
simulator, and I wanted to always update both, but it means that people's
new feature detection code can easily end up breaing their drm-shim
shader-db runs (such as intel's kernel_has_dynamic_config_support()
checking for -ENOENT instead of -EINVAL for a feature, which showed up on
my personal runner but not fd.o's for reasons I'm unclear on).
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5994>
Diffstat (limited to 'src/drm-shim')
| -rw-r--r-- | src/drm-shim/device.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/drm-shim/device.c b/src/drm-shim/device.c index 2ad25344087..97bb1183ea8 100644 --- a/src/drm-shim/device.c +++ b/src/drm-shim/device.c @@ -261,7 +261,7 @@ drm_shim_ioctl(int fd, unsigned long request, void *arg) nr, request); } - abort(); + return -EINVAL; } void |