summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>2019-06-06 16:31:01 +0200
committerJuan A. Suarez Romero <jasuarez@igalia.com>2019-06-11 07:58:06 +0000
commita7a2d403fd8983372e61f364ab23ad482e747235 (patch)
tree2b06748cfe443c746120c5e3ecd8ff661d559dd8
parent84bd361217d1a1ab6610368df60ad23b3cd7d94e (diff)
downloadmesa-a7a2d403fd8983372e61f364ab23ad482e747235.tar.gz
radv: fix alpha-to-coverage when there is unused color attachments
When alphaToCoverage is enabled, we should always write the alpha channel of MRT0 if it's unused. This now matches RadeonSI. This fixes the new CTS: dEQP-VK.pipeline.multisample.alpha_to_coverage_unused_attachment.samples_*.alpha_invisible Cc: 19.0 19.1 <mesa-stable@lists.freedesktop.org> Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-By: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl (cherry picked from commit 91aa25f4625014ddf194578fc1c1d0a505e5f8db)
-rw-r--r--src/amd/vulkan/radv_pipeline.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index f25a5f55bf5..773ccd8707a 100644
--- a/src/amd/vulkan/radv_pipeline.c
+++ b/src/amd/vulkan/radv_pipeline.c
@@ -524,7 +524,7 @@ radv_pipeline_compute_spi_color_formats(struct radv_pipeline *pipeline,
col_format |= cf << (4 * i);
}
- if (!col_format && blend->need_src_alpha & (1 << 0)) {
+ if (!(col_format & 0xf) && blend->need_src_alpha & (1 << 0)) {
/* When a subpass doesn't have any color attachments, write the
* alpha channel of MRT0 when alpha coverage is enabled because
* the depth attachment needs it.