diff options
author | Daniel P. Berrange <berrange@redhat.com> | 2018-01-11 16:42:12 +0000 |
---|---|---|
committer | Daniel P. Berrange <berrange@redhat.com> | 2018-01-12 18:15:54 +0000 |
commit | 948d77335ee33e78854e612fa51ce44506cdbb1a (patch) | |
tree | d0e57fbbf37547b534ad8e0468d21870a7a2f070 | |
parent | d11f4e41990573e55ed17ed684b615f2769bcb62 (diff) | |
download | libvirt-python-948d77335ee33e78854e612fa51ce44506cdbb1a.tar.gz |
Require libvirt native version matching py version by default
Although we're capable of building against any libvirt >= 0.9.11, 99% of the
time we want RPM builds to be done against matching libvirt version, otherwise
we might silently build against an unexpected/wrong version.
We don't support building against a native libvirt that's newer than the
python binding, since the generator may incorrectly handle new APIs. So use
== instead of >= too.
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
-rw-r--r-- | libvirt-python.spec.in | 2 | ||||
-rwxr-xr-x | setup.py | 3 |
2 files changed, 2 insertions, 3 deletions
diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 48a4933..2dfc84a 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -35,7 +35,7 @@ Source0: http://libvirt.org/sources/python/%{name}-%{version}.tar.gz Url: http://libvirt.org License: LGPLv2+ Group: Development/Libraries -BuildRequires: libvirt-devel >= @C_VERSION@ +BuildRequires: libvirt-devel == %{version} %if %{with_python2} %if %{py2_versioned_deps} BuildRequires: python2-devel @@ -175,8 +175,7 @@ class my_sdist(sdist): f2 = open('libvirt-python.spec', 'w') for line in f1: f2.write(line - .replace('@PY_VERSION@', self.distribution.get_version()) - .replace('@C_VERSION@', MIN_LIBVIRT)) + .replace('@PY_VERSION@', self.distribution.get_version())) f1.close() f2.close() |