diff options
author | Matthias Clasen <mclasen@redhat.com> | 2023-05-17 07:27:44 -0400 |
---|---|---|
committer | Matthias Clasen <mclasen@redhat.com> | 2023-05-17 07:28:45 -0400 |
commit | f8efc6f1fa0a93e8bc307877657ae1c40d6cd60f (patch) | |
tree | c10a1c70271f161a4cdfbfebb3305fac12ab56e1 | |
parent | e79851502c27105ad8c6a205bb577e70ee6681a4 (diff) | |
download | gtk+-gridview-critical.tar.gz |
gridview: Avoid a criticalgridview-critical
The code can hit this path with heights->len
being 0, and it does not seem to have any ill
effects, apart from this critical warning.
Fixes: #5836
-rw-r--r-- | gtk/gtkgridview.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/gtk/gtkgridview.c b/gtk/gtkgridview.c index 885826a138..f007ef8652 100644 --- a/gtk/gtkgridview.c +++ b/gtk/gtkgridview.c @@ -553,7 +553,8 @@ static int gtk_grid_view_get_unknown_row_size (GtkGridView *self, GArray *heights) { - g_return_val_if_fail (heights->len > 0, 0); + if (heights->len == 0) + return 0; /* return the median and hope rows are generally uniform with few outliers */ g_array_sort (heights, compare_ints); |