From f8efc6f1fa0a93e8bc307877657ae1c40d6cd60f Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Wed, 17 May 2023 07:27:44 -0400 Subject: gridview: Avoid a critical The code can hit this path with heights->len being 0, and it does not seem to have any ill effects, apart from this critical warning. Fixes: #5836 --- gtk/gtkgridview.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gtk/gtkgridview.c b/gtk/gtkgridview.c index 885826a138..f007ef8652 100644 --- a/gtk/gtkgridview.c +++ b/gtk/gtkgridview.c @@ -553,7 +553,8 @@ static int gtk_grid_view_get_unknown_row_size (GtkGridView *self, GArray *heights) { - g_return_val_if_fail (heights->len > 0, 0); + if (heights->len == 0) + return 0; /* return the median and hope rows are generally uniform with few outliers */ g_array_sort (heights, compare_ints); -- cgit v1.2.1