diff options
| author | Toon Claes <toon@gitlab.com> | 2019-07-05 10:53:16 +0200 |
|---|---|---|
| committer | Toon Claes <toon@gitlab.com> | 2019-07-05 10:54:16 +0200 |
| commit | 2b4573b555f9012237f6adef0d4f4b7c3288784c (patch) | |
| tree | 5f8e6bea20ad696703e0585ab316aeeedc1f3380 /doc/development/code_review.md | |
| parent | 1e11e6ad9a7c0f48e2779db39976a5aeee3770a6 (diff) | |
| download | gitlab-ce-database-review-docs.tar.gz | |
Further improve database review processdatabase-review-docs
Based on the comments, we're dropping the use of a "Database Review"
issue, and I'm improve Danger more to get database reviewers suggested
by roulette.
Diffstat (limited to 'doc/development/code_review.md')
| -rw-r--r-- | doc/development/code_review.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 6123f9f845a..51911cb7d13 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -62,6 +62,7 @@ from teams other than your own. **approved by a [backend maintainer](https://about.gitlab.com/handbook/engineering/projects/#gitlab-ce_maintainers_backend)**. 1. If your merge request includes database migrations or changes to expensive queries [^2], it must be **approved by a [database maintainer](https://about.gitlab.com/handbook/engineering/projects/#gitlab-ce_maintainers_database)**. + Read the [database review guidelines](database_review.md) for more details. 1. If your merge request includes frontend changes [^1], it must be **approved by a [frontend maintainer](https://about.gitlab.com/handbook/engineering/projects/#gitlab-ce_maintainers_frontend)**. 1. If your merge request includes UX changes [^1], it must be |