From 2b4573b555f9012237f6adef0d4f4b7c3288784c Mon Sep 17 00:00:00 2001 From: Toon Claes Date: Fri, 5 Jul 2019 10:53:16 +0200 Subject: Further improve database review process Based on the comments, we're dropping the use of a "Database Review" issue, and I'm improve Danger more to get database reviewers suggested by roulette. --- doc/development/code_review.md | 1 + 1 file changed, 1 insertion(+) (limited to 'doc/development/code_review.md') diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 6123f9f845a..51911cb7d13 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -62,6 +62,7 @@ from teams other than your own. **approved by a [backend maintainer](https://about.gitlab.com/handbook/engineering/projects/#gitlab-ce_maintainers_backend)**. 1. If your merge request includes database migrations or changes to expensive queries [^2], it must be **approved by a [database maintainer](https://about.gitlab.com/handbook/engineering/projects/#gitlab-ce_maintainers_database)**. + Read the [database review guidelines](database_review.md) for more details. 1. If your merge request includes frontend changes [^1], it must be **approved by a [frontend maintainer](https://about.gitlab.com/handbook/engineering/projects/#gitlab-ce_maintainers_frontend)**. 1. If your merge request includes UX changes [^1], it must be -- cgit v1.2.1