Explain why we use the unsigned int format for a signed int variable.

(Should 'code' be cast to the right pointer type?)

1 files changed, 4 insertions, 0 deletions

diff --git a/Modules/fcntlmodule.c b/Modules/fcntlmodule.c
index d109e29e7c..a368494c96 100644
--- a/Modules/fcntlmodule.c
+++ b/Modules/fcntlmodule.c
@@ -96,6 +96,10 @@ static PyObject *
 fcntl_ioctl(PyObject *self, PyObject *args)
 {
 	int fd;
+	/* In PyArg_ParseTuple below, use the unsigned int 'I' format for
+	   the signed int 'code' variable, because Python turns 0x8000000
+	   into a large positive number (PyLong, or PyInt on 64-bit
+	   platforms,) whereas C expects it to be a negative int */
 	int code;
 	int arg;
 	int ret;