summaryrefslogtreecommitdiff
path: root/Lib/threading.py
diff options
context:
space:
mode:
authorSerhiy Storchaka <storchaka@gmail.com>2014-09-21 22:08:13 +0300
committerSerhiy Storchaka <storchaka@gmail.com>2014-09-21 22:08:13 +0300
commit52005c2e13f32cfa3b6675997f2ef30adf0606a5 (patch)
tree821c9a3d8343f19f401826aaae15b99b71be1d2f /Lib/threading.py
parent3f40c40dea5f68fa4f1711c9cfa04c4edf6f8f53 (diff)
downloadcpython-git-52005c2e13f32cfa3b6675997f2ef30adf0606a5.tar.gz
Issue #22423: Unhandled exception in thread no longer causes unhandled
AttributeError when sys.stderr is None.
Diffstat (limited to 'Lib/threading.py')
-rw-r--r--Lib/threading.py16
1 files changed, 8 insertions, 8 deletions
diff --git a/Lib/threading.py b/Lib/threading.py
index dfe9d41b9f..7a5a4408ce 100644
--- a/Lib/threading.py
+++ b/Lib/threading.py
@@ -248,7 +248,7 @@ class Condition:
def _is_owned(self):
# Return True if lock is owned by current_thread.
- # This method is called only if __lock doesn't have _is_owned().
+ # This method is called only if _lock doesn't have _is_owned().
if self._lock.acquire(0):
self._lock.release()
return False
@@ -749,12 +749,12 @@ class Thread:
"""
- __initialized = False
+ _initialized = False
# Need to store a reference to sys.exc_info for printing
# out exceptions when a thread tries to use a global var. during interp.
# shutdown and thus raises an exception about trying to perform some
# operation on/with a NoneType
- __exc_info = _sys.exc_info
+ _exc_info = _sys.exc_info
# Keep sys.exc_clear too to clear the exception just before
# allowing .join() to return.
#XXX __exc_clear = _sys.exc_clear
@@ -926,10 +926,10 @@ class Thread:
# shutdown) use self._stderr. Otherwise still use sys (as in
# _sys) in case sys.stderr was redefined since the creation of
# self.
- if _sys:
- _sys.stderr.write("Exception in thread %s:\n%s\n" %
- (self.name, _format_exc()))
- else:
+ if _sys and _sys.stderr is not None:
+ print("Exception in thread %s:\n%s" %
+ (self.name, _format_exc()), file=self._stderr)
+ elif self._stderr is not None:
# Do the best job possible w/o a huge amt. of code to
# approximate a traceback (code ideas from
# Lib/traceback.py)
@@ -957,7 +957,7 @@ class Thread:
# test_threading.test_no_refcycle_through_target when
# the exception keeps the target alive past when we
# assert that it's dead.
- #XXX self.__exc_clear()
+ #XXX self._exc_clear()
pass
finally:
with _active_limbo_lock: