diff options
| author | Victor Stinner <victor.stinner@gmail.com> | 2017-09-14 08:43:04 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-09-14 08:43:04 -0700 |
| commit | 18e95b4176256f100429a806d0455406df98f984 (patch) | |
| tree | 93ee1ec40fe57593028605193ec1ccc45d7de841 /Lib/test/test_xmlrpc.py | |
| parent | 1bbd482bcf6ea36bfe488f868810ffe110238ae1 (diff) | |
| download | cpython-git-18e95b4176256f100429a806d0455406df98f984.tar.gz | |
bpo-31234: Join threads in tests (#3572)
Call thread.join() on threads to prevent the "dangling threads"
warning.
Diffstat (limited to 'Lib/test/test_xmlrpc.py')
| -rw-r--r-- | Lib/test/test_xmlrpc.py | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/Lib/test/test_xmlrpc.py b/Lib/test/test_xmlrpc.py index f2b496ac9a..c9099e0511 100644 --- a/Lib/test/test_xmlrpc.py +++ b/Lib/test/test_xmlrpc.py @@ -755,7 +755,9 @@ class BaseServerTestCase(unittest.TestCase): self.evt = threading.Event() # start server thread to handle requests serv_args = (self.evt, self.request_count, self.requestHandler) - threading.Thread(target=self.threadFunc, args=serv_args).start() + thread = threading.Thread(target=self.threadFunc, args=serv_args) + thread.start() + self.addCleanup(thread.join) # wait for the server to be ready self.evt.wait() @@ -1206,7 +1208,9 @@ class FailingServerTestCase(unittest.TestCase): self.evt = threading.Event() # start server thread to handle requests serv_args = (self.evt, 1) - threading.Thread(target=http_server, args=serv_args).start() + thread = threading.Thread(target=http_server, args=serv_args) + thread.start() + self.addCleanup(thread.join) # wait for the server to be ready self.evt.wait() |