diff options
author | Jason R. Coombs <jaraco@jaraco.com> | 2020-11-02 08:54:55 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-11-02 08:54:55 -0500 |
commit | 361543a7093ed93e74684e743cb62c772b4dbe55 (patch) | |
tree | 9503ac4161080db48afd30b4575d673a08726de1 /Lib/test/test_socketserver.py | |
parent | 3d86d090dcbbdfdd3e5a5951cab30612d6131222 (diff) | |
download | cpython-git-revert-13893-fix-issue-37193.tar.gz |
Revert "bpo-37193: remove thread objects which finished process its request (GH-13893)"revert-13893-fix-issue-37193
This reverts commit c41559021213cfc9dc62a83fc63306b3bdc3e64b.
Diffstat (limited to 'Lib/test/test_socketserver.py')
-rw-r--r-- | Lib/test/test_socketserver.py | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/Lib/test/test_socketserver.py b/Lib/test/test_socketserver.py index 1944795f05..7cdd115a95 100644 --- a/Lib/test/test_socketserver.py +++ b/Lib/test/test_socketserver.py @@ -277,13 +277,6 @@ class SocketServerTest(unittest.TestCase): t.join() s.server_close() - def test_close_immediately(self): - class MyServer(socketserver.ThreadingMixIn, socketserver.TCPServer): - pass - - server = MyServer((HOST, 0), lambda: None) - server.server_close() - def test_tcpserver_bind_leak(self): # Issue #22435: the server socket wouldn't be closed if bind()/listen() # failed. @@ -498,23 +491,6 @@ class MiscTestCase(unittest.TestCase): self.assertEqual(server.shutdown_called, 1) server.server_close() - def test_threads_reaped(self): - """ - In #37193, users reported a memory leak - due to the saving of every request thread. Ensure that the - threads are cleaned up after the requests complete. - """ - class MyServer(socketserver.ThreadingMixIn, socketserver.TCPServer): - pass - - server = MyServer((HOST, 0), socketserver.StreamRequestHandler) - for n in range(10): - with socket.create_connection(server.server_address): - server.handle_request() - [thread.join() for thread in server._threads] - self.assertEqual(len(server._threads), 0) - server.server_close() - if __name__ == "__main__": unittest.main() |