summaryrefslogtreecommitdiff
path: root/Lib/random.py
diff options
context:
space:
mode:
authorRaymond Hettinger <rhettinger@users.noreply.github.com>2021-10-16 10:16:53 -0500
committerGitHub <noreply@github.com>2021-10-16 10:16:53 -0500
commit5afa0a411243210a30526c7459a0ccff5cb88494 (patch)
tree4992ce242cf280b85395af4dfe06ffff2d8c4f45 /Lib/random.py
parent15ad52fbf607b6ccec44a38a8a32a5f1fad635ee (diff)
downloadcpython-git-5afa0a411243210a30526c7459a0ccff5cb88494.tar.gz
bpo-42222: Remove deprecated support for non-integer values (GH-28983)
Diffstat (limited to 'Lib/random.py')
-rw-r--r--Lib/random.py52
1 files changed, 10 insertions, 42 deletions
diff --git a/Lib/random.py b/Lib/random.py
index 3569d58cc4..92a71e14c4 100644
--- a/Lib/random.py
+++ b/Lib/random.py
@@ -286,27 +286,17 @@ class Random(_random.Random):
## -------------------- integer methods -------------------
def randrange(self, start, stop=None, step=_ONE):
- """Choose a random item from range(start, stop[, step]).
+ """Choose a random item from range(stop) or range(start, stop[, step]).
- This fixes the problem with randint() which includes the
- endpoint; in Python this is usually not what you want.
+ Roughly equivalent to ``choice(range(start, stop, step))``
+ but supports arbitrarily large ranges and is optimized
+ for common cases.
"""
# This code is a bit messy to make it fast for the
# common case while still doing adequate error checking.
- try:
- istart = _index(start)
- except TypeError:
- istart = int(start)
- if istart != start:
- _warn('randrange() will raise TypeError in the future',
- DeprecationWarning, 2)
- raise ValueError("non-integer arg 1 for randrange()")
- _warn('non-integer arguments to randrange() have been deprecated '
- 'since Python 3.10 and will be removed in a subsequent '
- 'version',
- DeprecationWarning, 2)
+ istart = _index(start)
if stop is None:
# We don't check for "step != 1" because it hasn't been
# type checked and converted to an integer yet.
@@ -316,37 +306,15 @@ class Random(_random.Random):
return self._randbelow(istart)
raise ValueError("empty range for randrange()")
- # stop argument supplied.
- try:
- istop = _index(stop)
- except TypeError:
- istop = int(stop)
- if istop != stop:
- _warn('randrange() will raise TypeError in the future',
- DeprecationWarning, 2)
- raise ValueError("non-integer stop for randrange()")
- _warn('non-integer arguments to randrange() have been deprecated '
- 'since Python 3.10 and will be removed in a subsequent '
- 'version',
- DeprecationWarning, 2)
+ # Stop argument supplied.
+ istop = _index(stop)
width = istop - istart
- try:
- istep = _index(step)
- except TypeError:
- istep = int(step)
- if istep != step:
- _warn('randrange() will raise TypeError in the future',
- DeprecationWarning, 2)
- raise ValueError("non-integer step for randrange()")
- _warn('non-integer arguments to randrange() have been deprecated '
- 'since Python 3.10 and will be removed in a subsequent '
- 'version',
- DeprecationWarning, 2)
+ istep = _index(step)
# Fast path.
if istep == 1:
if width > 0:
return istart + self._randbelow(width)
- raise ValueError("empty range for randrange() (%d, %d, %d)" % (istart, istop, width))
+ raise ValueError(f"empty range in randrange({start}, {stop}, {step})")
# Non-unit step argument supplied.
if istep > 0:
@@ -356,7 +324,7 @@ class Random(_random.Random):
else:
raise ValueError("zero step for randrange()")
if n <= 0:
- raise ValueError("empty range for randrange()")
+ raise ValueError(f"empty range in randrange({start}, {stop}, {step})")
return istart + istep * self._randbelow(n)
def randint(self, a, b):