diff options
| author | Pablo Galindo <Pablogsal@gmail.com> | 2019-11-19 21:34:03 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-11-19 21:34:03 +0000 |
| commit | 293dd23477eef6e7c1b1e26b5bb2c1e0d79ac3c2 (patch) | |
| tree | 295b4eee204f0d1e4723e62825a86310ddc27578 /Lib/multiprocessing/managers.py | |
| parent | c6b20be85c0de6f2355c67ae6e7e578941275cc0 (diff) | |
| download | cpython-git-293dd23477eef6e7c1b1e26b5bb2c1e0d79ac3c2.tar.gz | |
Remove binding of captured exceptions when not used to reduce the chances of creating cycles (GH-17246)
Capturing exceptions into names can lead to reference cycles though the __traceback__ attribute of the exceptions in some obscure cases that have been reported previously and fixed individually. As these variables are not used anyway, we can remove the binding to reduce the chances of creating reference cycles.
See for example GH-13135
Diffstat (limited to 'Lib/multiprocessing/managers.py')
| -rw-r--r-- | Lib/multiprocessing/managers.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Lib/multiprocessing/managers.py b/Lib/multiprocessing/managers.py index 75b5150f82..1f9c2daa25 100644 --- a/Lib/multiprocessing/managers.py +++ b/Lib/multiprocessing/managers.py @@ -248,7 +248,7 @@ class Server(object): try: obj, exposed, gettypeid = \ self.id_to_local_proxy_obj[ident] - except KeyError as second_ke: + except KeyError: raise ke if methodname not in exposed: @@ -296,7 +296,7 @@ class Server(object): try: try: send(msg) - except Exception as e: + except Exception: send(('#UNSERIALIZABLE', format_exc())) except Exception as e: util.info('exception in thread serving %r', |