diff options
| author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2021-06-02 21:04:20 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-06-02 21:04:20 -0700 |
| commit | 98e5a7975d99b58d511f171816ecdfb13d5cca18 (patch) | |
| tree | 0f5bdae7941d5dbadb5314e29bd26051eeddb6df | |
| parent | 9c89d62073fa0bcfe68e59add5b55fbcbf7672ab (diff) | |
| download | cpython-git-98e5a7975d99b58d511f171816ecdfb13d5cca18.tar.gz | |
bpo-44022: Improve the regression test. (GH-26503)
It wasn't actually detecting the regression due to the
assertion being too lenient.
(cherry picked from commit e60ab843cbb016fb6ff8b4f418641ac05a9b2fcc)
Co-authored-by: Gregory P. Smith <greg@krypto.org>
| -rw-r--r-- | Lib/test/test_httplib.py | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/Lib/test/test_httplib.py b/Lib/test/test_httplib.py index e9272569ec..8265b8d1d6 100644 --- a/Lib/test/test_httplib.py +++ b/Lib/test/test_httplib.py @@ -1186,7 +1186,12 @@ class BasicTest(TestCase): 'r\n' * 32768 ) resp = client.HTTPResponse(FakeSocket(body)) - self.assertRaises(client.HTTPException, resp.begin) + with self.assertRaises(client.HTTPException) as cm: + resp.begin() + # We must assert more because other reasonable errors that we + # do not want can also be HTTPException derived. + self.assertIn('got more than ', str(cm.exception)) + self.assertIn('headers', str(cm.exception)) def test_overflowing_chunked_line(self): body = ( |