summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2022-02-01 17:47:51 -0800
committerGitHub <noreply@github.com>2022-02-01 17:47:51 -0800
commit7dee93c2d223a080f410f6901987e9d363743471 (patch)
tree87b1397b91c16158b940508c132e9fb897dbf4c5
parente5e1441d41907f92cc3bb5de675a2c519068173d (diff)
downloadcpython-git-7dee93c2d223a080f410f6901987e9d363743471.tar.gz
bpo-46591: Make About IDLE doc link label clickable (GH-30251)
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 53c78080573b3bae4c4e782b9f47dce48aac9688) Co-authored-by: Wes <5124946+wesinator@users.noreply.github.com>
-rw-r--r--Lib/idlelib/NEWS.txt2
-rw-r--r--Lib/idlelib/help_about.py2
-rw-r--r--Lib/idlelib/idle_test/htest.py4
-rw-r--r--Misc/NEWS.d/next/Library/2022-01-31-15-40-38.bpo-46591.prBD1M.rst1
4 files changed, 7 insertions, 2 deletions
diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt
index bb78289ba8..724709a29f 100644
--- a/Lib/idlelib/NEWS.txt
+++ b/Lib/idlelib/NEWS.txt
@@ -4,6 +4,8 @@ Released on 2022-05-16
=========================
+bpo-46591: Make the IDLE doc URL on the About IDLE dialog clickable.
+
bpo-45296: Clarify close, quit, and exit in IDLE. In the File menu,
'Close' and 'Exit' are now 'Close Window' (the current one) and 'Exit'
is now 'Exit IDLE' (by closing all windows). In Shell, 'quit()' and
diff --git a/Lib/idlelib/help_about.py b/Lib/idlelib/help_about.py
index 019aacbd0f..c59f494599 100644
--- a/Lib/idlelib/help_about.py
+++ b/Lib/idlelib/help_about.py
@@ -3,6 +3,7 @@
"""
import os
import sys
+import webbrowser
from platform import python_version, architecture
from tkinter import Toplevel, Frame, Label, Button, PhotoImage
@@ -94,6 +95,7 @@ class AboutDialog(Toplevel):
f"{version[:version.rindex('.')]}/library/idle.html",
justify=LEFT, fg=self.fg, bg=self.bg)
docs.grid(row=7, column=0, columnspan=2, sticky=W, padx=10, pady=0)
+ docs.bind("<Button-1>", lambda event: webbrowser.open(docs['text']))
Frame(frame_background, borderwidth=1, relief=SUNKEN,
height=2, bg=self.bg).grid(row=8, column=0, sticky=EW,
diff --git a/Lib/idlelib/idle_test/htest.py b/Lib/idlelib/idle_test/htest.py
index 666ff4cb84..d297f8aa00 100644
--- a/Lib/idlelib/idle_test/htest.py
+++ b/Lib/idlelib/idle_test/htest.py
@@ -77,8 +77,8 @@ AboutDialog_spec = {
'kwds': {'title': 'help_about test',
'_htest': True,
},
- 'msg': "Test every button. Ensure Python, TK and IDLE versions "
- "are correctly displayed.\n [Close] to exit.",
+ 'msg': "Click on URL to open in default browser.\n"
+ "Verify x.y.z versions and test each button, including Close.\n "
}
# TODO implement ^\; adding '<Control-Key-\\>' to function does not work.
diff --git a/Misc/NEWS.d/next/Library/2022-01-31-15-40-38.bpo-46591.prBD1M.rst b/Misc/NEWS.d/next/Library/2022-01-31-15-40-38.bpo-46591.prBD1M.rst
new file mode 100644
index 0000000000..7785faa1c4
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2022-01-31-15-40-38.bpo-46591.prBD1M.rst
@@ -0,0 +1 @@
+Make the IDLE doc URL on the About IDLE dialog clickable. \ No newline at end of file