summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKyle Stanley <aeros167@gmail.com>2020-05-31 03:07:04 -0400
committerGitHub <noreply@github.com>2020-05-31 00:07:04 -0700
commit2b201369b435a4266bda5b895e3b615dbe28ea6e (patch)
tree75306b15a42274e929b3286f4a74368b983f205c
parent007bb06a2de9e64fa978f5dd9131d0100227b4cf (diff)
downloadcpython-git-2b201369b435a4266bda5b895e3b615dbe28ea6e.tar.gz
Fix asyncio.to_thread() documented return type (GH-20547)
When I wrote the documentation for `asyncio.to_thread()`, I mistakenly assumed that `return await loop.run_in_executor(...)` within an async def function would return a Future. In reality, it returns a coroutine. This likely won't affect typical usage of `asyncio.to_thread()`, but it's important for the documentation to be correct here. In general, we also tend to avoid returning futures from high-level APIs in asyncio.
-rw-r--r--Doc/library/asyncio-task.rst3
-rw-r--r--Lib/asyncio/threads.py2
2 files changed, 2 insertions, 3 deletions
diff --git a/Doc/library/asyncio-task.rst b/Doc/library/asyncio-task.rst
index 847363b134..21824ca537 100644
--- a/Doc/library/asyncio-task.rst
+++ b/Doc/library/asyncio-task.rst
@@ -614,8 +614,7 @@ Running in Threads
allowing context variables from the event loop thread to be accessed in the
separate thread.
- Return an :class:`asyncio.Future` which represents the eventual result of
- *func*.
+ Return a coroutine that can be awaited to get the eventual result of *func*.
This coroutine function is primarily intended to be used for executing
IO-bound functions/methods that would otherwise block the event loop if
diff --git a/Lib/asyncio/threads.py b/Lib/asyncio/threads.py
index 51e0ba95d8..34b7513a42 100644
--- a/Lib/asyncio/threads.py
+++ b/Lib/asyncio/threads.py
@@ -17,7 +17,7 @@ async def to_thread(func, /, *args, **kwargs):
allowing context variables from the main thread to be accessed in the
separate thread.
- Return an asyncio.Future which represents the eventual result of *func*.
+ Return a coroutine that can be awaited to get the eventual result of *func*.
"""
loop = events.get_running_loop()
ctx = contextvars.copy_context()