summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorŁukasz Langa <lukasz@langa.pl>2012-12-31 13:55:11 +0100
committerŁukasz Langa <lukasz@langa.pl>2012-12-31 13:55:11 +0100
commit0210194d48569ce136bad4d324ade03767356905 (patch)
tree13597f978bb3323a9d33d937a241ebf0d2d0dcb4
parent5da57027efb830f1bb6dfeecade94faee28b21ae (diff)
downloadcpython-git-0210194d48569ce136bad4d324ade03767356905.tar.gz
Fixes `__setitem__` on parser['DEFAULT'] reported in issue #16820.
-rw-r--r--Lib/configparser.py5
-rw-r--r--Lib/test/test_configparser.py28
2 files changed, 32 insertions, 1 deletions
diff --git a/Lib/configparser.py b/Lib/configparser.py
index be1c9f35da..eac508e412 100644
--- a/Lib/configparser.py
+++ b/Lib/configparser.py
@@ -960,7 +960,10 @@ class RawConfigParser(MutableMapping):
# XXX this is not atomic if read_dict fails at any point. Then again,
# no update method in configparser is atomic in this implementation.
- self.remove_section(key)
+ if key == self.default_section:
+ self._defaults.clear()
+ else:
+ self.remove_section(key)
self.read_dict({key: value})
def __delitem__(self, key):
diff --git a/Lib/test/test_configparser.py b/Lib/test/test_configparser.py
index 37dee744d1..3823641f56 100644
--- a/Lib/test/test_configparser.py
+++ b/Lib/test/test_configparser.py
@@ -797,6 +797,34 @@ boolean {0[0]} NO
self.assertEqual(set(cf.sections()), set())
self.assertEqual(set(cf[self.default_section].keys()), {'foo'})
+ def test_setitem(self):
+ cf = self.fromstring("""
+ [section1]
+ name1 {0[0]} value1
+ [section2]
+ name2 {0[0]} value2
+ [section3]
+ name3 {0[0]} value3
+ """.format(self.delimiters), defaults={"nameD": "valueD"})
+ self.assertEqual(set(cf['section1'].keys()), {'name1', 'named'})
+ self.assertEqual(set(cf['section2'].keys()), {'name2', 'named'})
+ self.assertEqual(set(cf['section3'].keys()), {'name3', 'named'})
+ self.assertEqual(cf['section1']['name1'], 'value1')
+ self.assertEqual(cf['section2']['name2'], 'value2')
+ self.assertEqual(cf['section3']['name3'], 'value3')
+ cf['section2'] = {'name22': 'value22'}
+ self.assertEqual(set(cf['section2'].keys()), {'name22', 'named'})
+ self.assertEqual(cf['section2']['name22'], 'value22')
+ self.assertNotIn('name2', cf['section2'])
+ cf['section3'] = {}
+ self.assertEqual(set(cf['section3'].keys()), {'named'})
+ self.assertNotIn('name3', cf['section3'])
+ cf[self.default_section] = {}
+ self.assertEqual(set(cf[self.default_section].keys()), set())
+ self.assertEqual(set(cf['section1'].keys()), {'name1'})
+ self.assertEqual(set(cf['section2'].keys()), {'name22'})
+ self.assertEqual(set(cf['section3'].keys()), set())
+
class StrictTestCase(BasicTestCase):
config_class = configparser.RawConfigParser