diff options
| author | Serhiy Storchaka <storchaka@gmail.com> | 2018-12-29 17:42:05 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-12-29 17:42:05 +0200 |
| commit | 13514f594de772d0e870ff680529d402b2ba8866 (patch) | |
| tree | 42e1290e446d69815b65dc95831cd681db345e59 | |
| parent | 78de01198b047347abc5e458851bb12c48429e24 (diff) | |
| download | cpython-git-revert-11341-bpo35603.tar.gz | |
Revert "bpo-35603: Escape table header of make_table output that can cause potential XSS. (GH-11341)"revert-11341-bpo35603
This reverts commit 78de01198b047347abc5e458851bb12c48429e24.
| -rw-r--r-- | Lib/difflib.py | 4 | ||||
| -rw-r--r-- | Lib/test/test_difflib.py | 9 | ||||
| -rw-r--r-- | Misc/NEWS.d/next/Library/2018-12-28-14-53-22.bpo-35603.rVCZAE.rst | 2 |
3 files changed, 0 insertions, 15 deletions
diff --git a/Lib/difflib.py b/Lib/difflib.py index 4571817b98..887c3c26ca 100644 --- a/Lib/difflib.py +++ b/Lib/difflib.py @@ -2036,10 +2036,6 @@ class HtmlDiff(object): s.append( fmt % (next_id[i],next_href[i],fromlist[i], next_href[i],tolist[i])) if fromdesc or todesc: - fromdesc = fromdesc.replace("&", "&").replace(">", ">") \ - .replace("<", "<") - todesc = todesc.replace("&", "&").replace(">", ">") \ - .replace("<", "<") header_row = '<thead><tr>%s%s%s%s</tr></thead>' % ( '<th class="diff_next"><br /></th>', '<th colspan="2" class="diff_header">%s</th>' % fromdesc, diff --git a/Lib/test/test_difflib.py b/Lib/test/test_difflib.py index 63ebdb0dc8..745ccbd665 100644 --- a/Lib/test/test_difflib.py +++ b/Lib/test/test_difflib.py @@ -238,15 +238,6 @@ class TestSFpatches(unittest.TestCase): with open(findfile('test_difflib_expect.html')) as fp: self.assertEqual(actual, fp.read()) - def test_make_table_escape_table_header(self): - html_diff = difflib.HtmlDiff() - output = html_diff.make_table(patch914575_from1.splitlines(), - patch914575_to1.splitlines(), - fromdesc='<from>', - todesc='<to>') - self.assertIn('<from>', output) - self.assertIn('<to>', output) - def test_recursion_limit(self): # Check if the problem described in patch #1413711 exists. limit = sys.getrecursionlimit() diff --git a/Misc/NEWS.d/next/Library/2018-12-28-14-53-22.bpo-35603.rVCZAE.rst b/Misc/NEWS.d/next/Library/2018-12-28-14-53-22.bpo-35603.rVCZAE.rst deleted file mode 100644 index 03150c3aa4..0000000000 --- a/Misc/NEWS.d/next/Library/2018-12-28-14-53-22.bpo-35603.rVCZAE.rst +++ /dev/null @@ -1,2 +0,0 @@ -Escape table header output of :meth:`difflib.HtmlDiff.make_table`. -Patch by Karthikeyan Singaravelan. |