diff options
| author | Randall Spangler <rspangler@chromium.org> | 2016-09-07 16:41:48 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-09-14 13:05:04 -0700 |
| commit | 8f400498c68098d024170ccbcb4b3018b3417799 (patch) | |
| tree | 522e848f99662dcaadbcea08fb3bc609198ddd2d /utility/load_kernel_test.c | |
| parent | d8a9ede87c0a0b804ef17c60f3b2baac3498f6ae (diff) | |
| download | vboot-8f400498c68098d024170ccbcb4b3018b3417799.tar.gz | |
utilities: Fix coverity warnings
Assorted minor code issues, which we should fix so any new errors stand
out more.
BUG=chromium:643769
BRANCH=none
TEST=make runtests
Change-Id: Ifcb50b3dfcc3d376bf6803e9c06f8e68dafd51a0
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/382611
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'utility/load_kernel_test.c')
| -rw-r--r-- | utility/load_kernel_test.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/utility/load_kernel_test.c b/utility/load_kernel_test.c index a2800bfa..ee385bf1 100644 --- a/utility/load_kernel_test.c +++ b/utility/load_kernel_test.c @@ -43,8 +43,8 @@ VbError_t VbExDiskRead(VbExDiskHandle_t handle, uint64_t lba_start, return 1; } - fseek(image_file, lba_start * lkp.bytes_per_lba, SEEK_SET); - if (1 != fread(buffer, lba_count * lkp.bytes_per_lba, 1, image_file)) { + if (0 != fseek(image_file, lba_start * lkp.bytes_per_lba, SEEK_SET) || + 1 != fread(buffer, lba_count * lkp.bytes_per_lba, 1, image_file)) { fprintf(stderr, "Read error."); return 1; } @@ -152,6 +152,11 @@ int main(int argc, char* argv[]) { return 1; } printf("Read %" PRIu64 " bytes of key from %s\n", key_size, argv[optind+1]); + if (key_size > 16*1024*1024) { + fprintf(stderr, "Key blob size=%" PRIu64 " is ridiculous.\n", key_size); + free(key_blob); + return 1; + } } /* Initialize the GBB */ |