diff options
author | Randall Spangler <rspangler@chromium.org> | 2014-06-05 13:32:11 -0700 |
---|---|---|
committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-06-07 01:37:21 +0000 |
commit | b9be53640efdee92b1b42e60adda274563236301 (patch) | |
tree | f8f2f5ef809c7a0d163334f9e2675b016fae3ca4 /tests/vb2_nvstorage_tests.c | |
parent | b64f097891e697eaf3b2794baae934f8b4d82d14 (diff) | |
download | vboot-b9be53640efdee92b1b42e60adda274563236301.tar.gz |
vboot2: Use more specific error codesstabilize-5944.Bstabilize-5943.Bstabilize-5942.Bfactory-samus-5939.B
Error codes reported by the crypto and storage APIs are now very
specific, and tests verify the proper errors are reported.
More specific error codes coming to other files next, but I don't want
this CL to get too long.
This also changes test_common.c so TEST_EQ() reports mismatched values
in both decimal and hex, and adds TEST_SUCC() to test for a successful
return value.
BUG=chromium:370082
BRANCH=none
TEST=make clean && VBOOT2=1 COV=1 make
Change-Id: I255c8e5769284fbc286b9d94631b19677a71cdd0
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/202778
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Diffstat (limited to 'tests/vb2_nvstorage_tests.c')
-rw-r--r-- | tests/vb2_nvstorage_tests.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/tests/vb2_nvstorage_tests.c b/tests/vb2_nvstorage_tests.c index 061f8691..88ffe477 100644 --- a/tests/vb2_nvstorage_tests.c +++ b/tests/vb2_nvstorage_tests.c @@ -79,6 +79,7 @@ static void nv_storage_test(void) "vb2_nv_init() status changed"); test_changed(&c, 1, "vb2_nv_init() reset changed"); goodcrc = c.nvdata[15]; + TEST_SUCC(vb2_nv_check_crc(&c), "vb2_nv_check_crc() good"); /* Another init should not cause further changes */ c.flags = 0; @@ -90,6 +91,8 @@ static void nv_storage_test(void) /* Perturbing the header should force defaults */ c.nvdata[0] ^= 0x40; + TEST_EQ(vb2_nv_check_crc(&c), + VB2_ERROR_NV_HEADER, "vb2_nv_check_crc() bad header"); vb2_nv_init(&c); TEST_EQ(c.nvdata[0], 0x70, "vb2_nv_init() reset header byte again"); test_changed(&c, 1, "vb2_nv_init() corrupt changed"); @@ -98,6 +101,8 @@ static void nv_storage_test(void) /* So should perturbing some other byte */ TEST_EQ(c.nvdata[11], 0, "Kernel byte starts at 0"); c.nvdata[11] = 12; + TEST_EQ(vb2_nv_check_crc(&c), + VB2_ERROR_NV_CRC, "vb2_nv_check_crc() bad CRC"); vb2_nv_init(&c); TEST_EQ(c.nvdata[11], 0, "vb2_nv_init() reset kernel byte"); test_changed(&c, 1, "vb2_nv_init() corrupt elsewhere changed"); |