diff options
| author | Mike Frysinger <vapier@chromium.org> | 2019-08-21 14:58:26 -0400 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-08-26 18:55:07 +0000 |
| commit | fdb750c74ff1ff9a145f4deb5cd6caa32ab8b72a (patch) | |
| tree | afe05702cc9acac04f93ce41664016ebd7b814af /scripts/image_signing/sign_official_build.sh | |
| parent | 595108c06a4a37f4d33f66052add2e7e0176cf1b (diff) | |
| download | vboot-fdb750c74ff1ff9a145f4deb5cd6caa32ab8b72a.tar.gz | |
ensure_secure_kernelparams: add sanity checks on baseline sed scripts
The way the sed logic was written we allowed invalid sed expressions
to count as "pass". This is because we use "no output" as the signal
that the command line option is OK (since the sed script deleted it),
but it meant that invalid sed scripts produced no output too. Add an
explicit exit status check to make sure invalid scripts fail.
BUG=chromium:991590
TEST=`./image_signing/ensure_secure_kernelparams.sh ./coral-12439.0.0-recovery.bin .../cros-signing/security_test_baselines/ensure_secure_kernelparams.config` produces no errors
BRANCH=None
Change-Id: I1de3ada7e44c49f97ecc40824d98cca9291ab7e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1762459
Reviewed-by: LaMont Jones <lamontjones@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Diffstat (limited to 'scripts/image_signing/sign_official_build.sh')
0 files changed, 0 insertions, 0 deletions