diff options
| author | Randall Spangler <rspangler@chromium.org> | 2016-09-02 12:25:27 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-09-14 13:05:02 -0700 |
| commit | d8a9ede87c0a0b804ef17c60f3b2baac3498f6ae (patch) | |
| tree | c88b1a975f5eccc27767cf2e53b224656eafe25f /futility/cmd_gbb_utility.c | |
| parent | afa7350dccee079673831ef16a7c60a9a74ba77f (diff) | |
| download | vboot-d8a9ede87c0a0b804ef17c60f3b2baac3498f6ae.tar.gz | |
futility/host lib: Fix coverity warnings
Assorted minor code issues, which we should fix so any new errors stand
out more.
BUG=chromium:643769
BRANCH=none
TEST=make runtests
Change-Id: Ib37b45dea54bd506b519b0304300b8d192e34339
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/382319
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'futility/cmd_gbb_utility.c')
| -rw-r--r-- | futility/cmd_gbb_utility.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/futility/cmd_gbb_utility.c b/futility/cmd_gbb_utility.c index fe21762e..f75cceb0 100644 --- a/futility/cmd_gbb_utility.c +++ b/futility/cmd_gbb_utility.c @@ -235,9 +235,10 @@ static uint8_t *read_entire_file(const char *filename, off_t *sizeptr) goto fail; } - if (fp && 0 != fclose(fp)) { + if (0 != fclose(fp)) { fprintf(stderr, "ERROR: Unable to close %s: %s\n", filename, strerror(errno)); + fp = NULL; /* Don't try to close it again */ goto fail; } |