From d8a9ede87c0a0b804ef17c60f3b2baac3498f6ae Mon Sep 17 00:00:00 2001 From: Randall Spangler Date: Fri, 2 Sep 2016 12:25:27 -0700 Subject: futility/host lib: Fix coverity warnings Assorted minor code issues, which we should fix so any new errors stand out more. BUG=chromium:643769 BRANCH=none TEST=make runtests Change-Id: Ib37b45dea54bd506b519b0304300b8d192e34339 Signed-off-by: Randall Spangler Reviewed-on: https://chromium-review.googlesource.com/382319 Reviewed-by: Daisuke Nojiri --- futility/cmd_gbb_utility.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'futility/cmd_gbb_utility.c') diff --git a/futility/cmd_gbb_utility.c b/futility/cmd_gbb_utility.c index fe21762e..f75cceb0 100644 --- a/futility/cmd_gbb_utility.c +++ b/futility/cmd_gbb_utility.c @@ -235,9 +235,10 @@ static uint8_t *read_entire_file(const char *filename, off_t *sizeptr) goto fail; } - if (fp && 0 != fclose(fp)) { + if (0 != fclose(fp)) { fprintf(stderr, "ERROR: Unable to close %s: %s\n", filename, strerror(errno)); + fp = NULL; /* Don't try to close it again */ goto fail; } -- cgit v1.2.1