diff options
| author | Mike Frysinger <vapier@chromium.org> | 2016-09-07 20:23:46 -0400 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-09-08 06:14:45 -0700 |
| commit | c60eb7e735bbd6d401d7c3c73a7950461cd86d05 (patch) | |
| tree | 842c13348c102c5ce711a01e97cd95c3ade36527 /cgpt/cmd_show.c | |
| parent | 61c4ee12be495fe60b94b60f768be0f6a539fd05 (diff) | |
| download | vboot-c60eb7e735bbd6d401d7c3c73a7950461cd86d05.tar.gz | |
cgpt: unify cli int parsing error checking
Most of the cmd funcs had the same logic copied & pasted multiple times
over. Unify them into a common header.
BUG=chromium:644845
TEST=precq passes
TEST=passing invalid args to some funcs is caught
BRANCH=None
Change-Id: Ib7212bcbb17da1135b2508a52910aac37ee8e6cd
Reviewed-on: https://chromium-review.googlesource.com/382691
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'cgpt/cmd_show.c')
| -rw-r--r-- | cgpt/cmd_show.c | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/cgpt/cmd_show.c b/cgpt/cmd_show.c index dcfefdd3..c5a5f445 100644 --- a/cgpt/cmd_show.c +++ b/cgpt/cmd_show.c @@ -52,11 +52,7 @@ int cmd_show(int argc, char *argv[]) { { case 'D': params.drive_size = strtoull(optarg, &e, 0); - if (!*optarg || (e && *e)) - { - Error("invalid argument to -%c: \"%s\"\n", c, optarg); - errorcnt++; - } + errorcnt += check_int_parse(c, e); break; case 'n': params.numeric = 1; @@ -69,11 +65,7 @@ int cmd_show(int argc, char *argv[]) { break; case 'i': params.partition = (uint32_t)strtoul(optarg, &e, 0); - if (!*optarg || (e && *e)) - { - Error("invalid argument to -%c: \"%s\"\n", c, optarg); - errorcnt++; - } + errorcnt += check_int_parse(c, e); break; case 'b': case 's': |