diff options
| author | Manoj Gupta <manojgupta@google.com> | 2019-08-27 15:45:39 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-08-28 19:37:14 +0000 |
| commit | afd52397565311166a97f7681209c2f9d3a2d37a (patch) | |
| tree | 42b978dbc7e0dfa1729cf3c8de7e842915eb9648 /cgpt/cmd_add.c | |
| parent | 090279951f8cd0f23bf38c4fb72c2b1f3a465ddf (diff) | |
| download | vboot-afd52397565311166a97f7681209c2f9d3a2d37a.tar.gz | |
Fix fall through warning reported by ToT clang.
Clang is diagnosing implicit fallthrough in C code
past https://reviews.llvm.org/rL369414.
Detect the support for the fallthrough attributes in gcc/clang
and enable it as VBOOT_FALLTHROUGH (copied from boringssl).
This is needed to fix ToT clang builds.
Note: GCC apparently does not diagnose fallthrough to another case
with break but clang does (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91432).
And clang does not detect the fallthrough based on code comments.
Bug: chromium:997709
Test: CQ
Change-Id: Id8b4be4deabca2d0f1b2efd80efa72a485a5dc8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1772474
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Diffstat (limited to 'cgpt/cmd_add.c')
0 files changed, 0 insertions, 0 deletions