diff options
| author | Nam T. Nguyen <namnguyen@chromium.org> | 2014-11-13 19:30:46 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-11-14 22:46:59 +0000 |
| commit | ab899591808dd3e5f955ab7693b54a83389cd35f (patch) | |
| tree | 8d12700b5be62ac132fd09e3cb17f6b6cce4b70c /cgpt/cmd_add.c | |
| parent | a524a3a51591618c1395cb9e1238ee72b3f5e767 (diff) | |
| download | vboot-ab899591808dd3e5f955ab7693b54a83389cd35f.tar.gz | |
vboot: cgpt: Treat drive_path as the GPT storage
Previously, "cgpt" called out to "flashrom" directly to read and write
NOR area. This CL removes that dependency and always treats "drive_path"
as the storage of GPT structs. This makes it consistent that whatever
device that cgpt reads from or writes to is always the device that
stores GPT structs. We only need to pass in the size of the drive that
contains the partitions, but we do not need to access to that drive.
More information is in the bug.
BUG=chromium:432611
BRANCH=none
TEST=unittest
CQ-DEPEND=CL:228942
Change-Id: Id0139adf70463cec4f2924de8b9a4725dbec822b
Reviewed-on: https://chromium-review.googlesource.com/229736
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Commit-Queue: Nam Nguyen <namnguyen@chromium.org>
Tested-by: Nam Nguyen <namnguyen@chromium.org>
Diffstat (limited to 'cgpt/cmd_add.c')
| -rw-r--r-- | cgpt/cmd_add.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/cgpt/cmd_add.c b/cgpt/cmd_add.c index 2bb5df43..0d89065b 100644 --- a/cgpt/cmd_add.c +++ b/cgpt/cmd_add.c @@ -15,6 +15,9 @@ static void Usage(void) printf("\nUsage: %s add [OPTIONS] DRIVE\n\n" "Add, edit, or remove a partition entry.\n\n" "Options:\n" + " -D NUM Size (in bytes) of the disk where partitions reside\n" + " default 0, meaning partitions and GPT structs are\n" + " both on DRIVE\n" " -i NUM Specify partition (default is next available)\n" " -b NUM Beginning sector\n" " -s NUM Size in sectors\n" @@ -42,10 +45,18 @@ int cmd_add(int argc, char *argv[]) { char *e = 0; opterr = 0; // quiet, you - while ((c=getopt(argc, argv, ":hi:b:s:t:u:l:S:T:P:A:")) != -1) + while ((c=getopt(argc, argv, ":hi:b:s:t:u:l:S:T:P:A:D:")) != -1) { switch (c) { + case 'D': + params.drive_size = strtoull(optarg, &e, 0); + if (!*optarg || (e && *e)) + { + Error("invalid argument to -%c: \"%s\"\n", c, optarg); + errorcnt++; + } + break; case 'i': params.partition = (uint32_t)strtoul(optarg, &e, 0); if (!*optarg || (e && *e)) |