diff options
author | Bill Richardson <wfrichar@chromium.org> | 2013-03-20 15:02:34 -0700 |
---|---|---|
committer | ChromeBot <chrome-bot@google.com> | 2013-03-20 23:47:50 -0700 |
commit | 3f806a2abf07d7b801852a4a6f3a9080a4b5c427 (patch) | |
tree | 936deb68cac1010957023c1e7cc8f2988feddd25 /cgpt/cgpt_common.c | |
parent | 95bae09c7e54a604d89f16b4a8e8b946642af8e7 (diff) | |
download | vboot-3f806a2abf07d7b801852a4a6f3a9080a4b5c427.tar.gz |
Apply consistent naming scheme for hostlib functions.
The chromeos-installer uses several functions from the vboot_reference
userspace library, but the names of those functions are inconsistent:
IsZero
MapFile
VbGetSystemPropertyString
cgpt_add
cgpt_boot
cgpt_create
cgpt_get_boot_partition_number
cgpt_get_num_non_empty_partitions
cgpt_get_partition_details
cgpt_prioritize
cgpt_set_attributes
find_kernel_config
The Google C++ style guide says types and functions should use CamelCase,
while variables use lower_case_with_underscores.
Kernel style (which vboot_reference tries to be more-or-less compatible
with) uses lower_case_with_underscores for everything, but that really only
has to apply to firmware stuff. For userspace, we can use the Google style.
BUG=chromium:221544
BRANCH=none
TEST=buildbot
CQ-DEPEND=CL:46045
Renaming/cleanup only; no functional changes.
Change-Id: I9c82c9ff8909be88586194c8ffdb435fc771195f
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/46044
Diffstat (limited to 'cgpt/cgpt_common.c')
-rw-r--r-- | cgpt/cgpt_common.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/cgpt/cgpt_common.c b/cgpt/cgpt_common.c index 8def05ef..dc42d41f 100644 --- a/cgpt/cgpt_common.c +++ b/cgpt/cgpt_common.c @@ -872,13 +872,13 @@ int GuidEqual(const Guid *guid1, const Guid *guid2) { return (0 == memcmp(guid1, guid2, sizeof(Guid))); } -int IsZero(const Guid *gp) { +int GuidIsZero(const Guid *gp) { return GuidEqual(gp, &guid_unused); } void PMBRToStr(struct pmbr *pmbr, char *str, unsigned int buflen) { char buf[GUID_STRLEN]; - if (IsZero(&pmbr->boot_guid)) { + if (GuidIsZero(&pmbr->boot_guid)) { require(snprintf(str, buflen, "PMBR") < buflen); } else { GuidToStr(&pmbr->boot_guid, buf, sizeof(buf)); |